Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/Streamline Profile Options #335

Open
jdtoppin opened this issue Jun 26, 2024 · 3 comments
Open

Simplify/Streamline Profile Options #335

jdtoppin opened this issue Jun 26, 2024 · 3 comments
Labels
enhancement New feature or request needs-triage

Comments

@jdtoppin
Copy link

Is your feature request related to a problem? Please describe.

Currently, the settings in the Profile menu are confusing, especially since there isn't documentation online or in the app explaining how Profile options work. While it is somewhat self explanatory, new users may be confused as to why you would use a profile versus a temporary target for example or a specific profile option. Moreover, the way in which you enter the time on a 24h clock is not consistent with iOS ux.

Describe the solution you'd like

Options should be split up into corresponding sections to show context for which options in the profile menu are related. There should also be contextual explanations for each setting like the rest of the preferences that explain what each option does and what it changes when you tap the option. The schedule SMBs times should be changed to a scroll-able time picker with minutes that aligns with iOS designs for continuity with the OS.

Describe alternatives you've considered

No real alternative for now. Use of the profiles is fine, but given the lack of guardrails, Profiles should be considered an advanced feature with warning text given the lack of guardrails (#185).

Additional context

I think this issue has been discussed in other mediums previously.

Technical Details

As per previous section, may rely on other issues moving forward such as #181 or #185.

User Impact

For now, impact is that new users are unclear of the functionality that profiles offer.

@jdtoppin jdtoppin added enhancement New feature or request needs-triage labels Jun 26, 2024
@jdtoppin jdtoppin changed the title Simplify Profile Options Simplify/Streamline Profile Options Jun 26, 2024
@dnzxy
Copy link
Contributor

dnzxy commented Jun 28, 2024

Thanks for the feature request and nice to see you again 😊

but given the lack of guardrails

Could you go a bit into detail what you mean by this, please?

@jdtoppin
Copy link
Author

jdtoppin commented Jul 1, 2024

Nice to see you too! Sorry for the late reply here, been dealing with covid all weekend.

Yes, akin to #185, a user can set both extremely high insulin factors and whatever targets they want. Given the lack of warnings or explanations, this could lead to a user entering in a value that may not be what they wanted. Not only that, but a confirmation explaining xx% means you will get this much more insulin would be helpful. While TT and profiles follow other controls (max iob, etc), it could still result in scenarios where you receive much more insulin or not enough based on incorrect input or a lack of understanding.

mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
@dnzxy
Copy link
Contributor

dnzxy commented Aug 8, 2024

Coming back to this since it was mentioned elsewhere. I think there is a mix of two things here present now.

  1. input validation
  2. explanation

I do have to say I still don’t really get what more hints you require other than the ones that are already found in that view, namely

"Your profile basal insulin will be adjusted with the percentage and your profile ISF and CR will be inversely adjusted with the percentage".

Disable SMB is a toggle that will disable SMBs and changing the minutes will change the minutes. Does this need hinting in the context of overrides?

After a user goes into setting overrides, they will have already been using the app, will have gone through settings (which we will work on to extend with more information; not related to this issue but want to mention it) and should know what that means all means.

What hint is missing there? Or what "logic" are you missing? It is definitely missing input validation so users cannot introduce insane changes. Even the mighty Loop with all its limitations has explanations for overrides in its documentation, not in the view. Just trying to understand the scope of your proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage
Projects
None yet
Development

No branches or pull requests

2 participants