Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recognition for <prefix><unit_surface> combinations #183

Open
nielstron opened this issue Dec 5, 2020 · 1 comment
Open

Add recognition for <prefix><unit_surface> combinations #183

nielstron opened this issue Dec 5, 2020 · 1 comment

Comments

@nielstron
Copy link
Owner

Is your feature request related to a problem? Please describe.
As pointed out in a seperate issue, the combination "<unit_surface>" (i.e. "Mlitre") is not uncommon. Therefore support for its recognition would be desirable.

An example for the usage of such notation:
https://www.climate-policy-watcher.org/water-quality/v-1.html

Additional context
https://github.com/nielstron/quantulum3/pull/162/files#r533194554

@nielstron
Copy link
Owner Author

nielstron commented Dec 5, 2020

Some quick test in branc feature-prefix-surface-recognition reveals that a bit more fine tuning will be needed:

currently, it is also allowed to mix symbolic and non-symbolic units without spaces. This yields "metre litre per day" for the term "Mlitre/day" from the example above. This only partly gets resolved later by a manual override to convert "M" and "k" to 10^3/10^6 multipliers.
The overall result (15*10^6 litre/day) is only partially desired, as we usually do not want to do unit conversion, which implicitely happens here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant