Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi I'm adding a new language (Spanish) and i have an issue! #156

Open
tmullerv opened this issue Jul 29, 2020 · 4 comments
Open

Hi I'm adding a new language (Spanish) and i have an issue! #156

tmullerv opened this issue Jul 29, 2020 · 4 comments

Comments

@tmullerv
Copy link

Hi thanks for reading. I'm trying to add a new language and i have an issue, as i try to add units to units.js in _lang.es_CL, it seems that entities.json from es_CL are not loaded beforehand thus not finding it in entities, as i could resolve the problem by adding the entitie to main entities.json file. Am i missing something? is this the expecte behaviour?

I'm really pleased with the use of this library in english so i'm very compromised on getting it to work on spanish.
thx again
image

@nielstron
Copy link
Owner

Thats a very cool project! Unfortunately, if you don't show me what changes you made to the code, I cannot debug the issue. Maybe you can push your changes to a branch on your fork?

@tmullerv
Copy link
Author

tmullerv commented Aug 3, 2020

I did pushed to a new branch in my fork (ES_dev) if u could check it out, the problem solves when i manually add the entities to the main entities.json file. You could try that too just copying the ones from the es_CL/entities.json

@tmullerv
Copy link
Author

tmullerv commented Aug 3, 2020

After that the next error i get is this, i believe is because i havent retrained the classifier. I'll translate the train.json an try to retrain the classifier.

image

@lizozom
Copy link

lizozom commented Feb 13, 2023

Hey @tmullerv Did you end up finishing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants