From e60e673d383e1fdd272a390ab9aea239630dbfa7 Mon Sep 17 00:00:00 2001 From: Ken Lim <111891+kenlim@users.noreply.github.com> Date: Mon, 13 Mar 2023 23:18:16 +0000 Subject: [PATCH 1/3] Corrected "search_subfolder" instructions The option to search for csvs within Subfolders seems to have changed from "search_subfolders" to "search_subdirectories". I have updated the documentation to match. --- docs/how-to-configure.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/how-to-configure.md b/docs/how-to-configure.md index a3a18f6e..3536ff1b 100644 --- a/docs/how-to-configure.md +++ b/docs/how-to-configure.md @@ -29,11 +29,11 @@ Set to `true` to always use `import_from` without confirmation **Optional.** -### `search_subfolders` +### `search_subdirectories` ```yaml -search_subfolders: false # only search the top folder for bank files -search_subfolders: true # search underlying folders as well +search_subdirectories: false # only search the top folder for bank files +search_subdirectories: true # search underlying folders as well ``` ### `configuration_done` From a928b1dfbafd71310ac4d451eb85fa902b15b6b5 Mon Sep 17 00:00:00 2001 From: Niels Maerten Date: Tue, 14 Mar 2023 08:14:20 +0000 Subject: [PATCH 2/3] fix: change "subfolders" to "subdirectories" in example config file and test fixtures --- assets/config/example.yaml | 2 +- src/lib/configuration.spec.fixture.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/config/example.yaml b/assets/config/example.yaml index 5890655f..c0a3a0cc 100644 --- a/assets/config/example.yaml +++ b/assets/config/example.yaml @@ -8,7 +8,7 @@ # https://github.com/nielsmaerten/ynab-buddy/blob/main/docs/how-to-configure.md import_from: "c:/users/test/downloads" -search_subfolders: true +search_subdirectories: true bank_transaction_files: # Repeat the following block for every account: diff --git a/src/lib/configuration.spec.fixture.ts b/src/lib/configuration.spec.fixture.ts index f545b28e..aea84a02 100644 --- a/src/lib/configuration.spec.fixture.ts +++ b/src/lib/configuration.spec.fixture.ts @@ -15,7 +15,7 @@ export const configFile = `####################################### # https://github.com/nielsmaerten/ynab-buddy/blob/main/docs/how-to-configure.md import_from: "c:/users/test/downloads" -search_subfolders: true +search_subdirectories: true bank_transaction_files: # Repeat the following block for every account: From 8698c657372c34e6fb218336ab27287506128647 Mon Sep 17 00:00:00 2001 From: Niels Maerten Date: Tue, 14 Mar 2023 08:19:16 +0000 Subject: [PATCH 3/3] test(config): fix test --- src/lib/configuration.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/configuration.spec.ts b/src/lib/configuration.spec.ts index b24dd017..fd2d69d1 100644 --- a/src/lib/configuration.spec.ts +++ b/src/lib/configuration.spec.ts @@ -75,7 +75,7 @@ describe("configuration", () => { name: "bnp-example-parser", }, ], - searchSubDirectories: false, + searchSubDirectories: true, importPath: "c:/users/test/downloads", ynab: { token: "ABC12345",