Skip to content
This repository has been archived by the owner on May 23, 2019. It is now read-only.

Maintenance on dependencies and scripts. #86

Open
Announcement opened this issue Nov 21, 2017 · 1 comment
Open

Maintenance on dependencies and scripts. #86

Announcement opened this issue Nov 21, 2017 · 1 comment

Comments

@Announcement
Copy link

npm WARN deprecated [email protected]: uglifyjs is deprecated - use uglify-js instead.
npm WARN engine [email protected]: wanted: {"node":">= 4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">=4"} (current: {"node":"0.12.18","npm":"2.15.11"})

these can easily be fixed in the build process, is there a particular reason the dependencies haven't been updated?

Additionally, why is make being use instead of npm scripts? it seems a bit odd and breaks compatibility for windows...

@Announcement
Copy link
Author

Announcement commented Nov 22, 2017

https://github.com/Announcement/algebra.js/tree/maintenance is along the lines of this proposal

  • unfortunately istanbul requires a bit of extra configuration that's what nyc is for

  • rm -rf doesn't work on windows, so it's common practice to use rimraf for that but I won't do that unless we're in agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant