You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the asset/currency pair is set as an exchange property. This means that strategies will only be able to trade on one pair and use information respective to that. Was this a conscious design choice?
If not, I would argue that it would be better to let it fall into a strategy's responsibility to decide on what pair to trade, e.g. by initialising a generic strategy with the pair i want it to trade or having a strategy that is optimised for a certain set of (multiple) coins.
Anyway, for now I implemented a quick pair class and pulled the pair dependency out of the exchange, for you to have a look.
Tell me what you think.
Cheers
The text was updated successfully, but these errors were encountered:
This is a good idea, I used to rewrite this project using PHP8 and Symfony, in this other project I have a Market entity which only contain an exchange reference and the base and quote assets pair to support multi exchange feature.
Hi again,
I noticed that the asset/currency pair is set as an exchange property. This means that strategies will only be able to trade on one pair and use information respective to that. Was this a conscious design choice?
If not, I would argue that it would be better to let it fall into a strategy's responsibility to decide on what pair to trade, e.g. by initialising a generic strategy with the pair i want it to trade or having a strategy that is optimised for a certain set of (multiple) coins.
Anyway, for now I implemented a quick
pair
class and pulled the pair dependency out of the exchange, for you to have a look.Tell me what you think.
Cheers
The text was updated successfully, but these errors were encountered: