Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset/Currency as exchange properties #13

Open
cxkoda opened this issue Apr 20, 2021 · 1 comment · May be fixed by #14
Open

Asset/Currency as exchange properties #13

cxkoda opened this issue Apr 20, 2021 · 1 comment · May be fixed by #14

Comments

@cxkoda
Copy link

cxkoda commented Apr 20, 2021

Hi again,

I noticed that the asset/currency pair is set as an exchange property. This means that strategies will only be able to trade on one pair and use information respective to that. Was this a conscious design choice?
If not, I would argue that it would be better to let it fall into a strategy's responsibility to decide on what pair to trade, e.g. by initialising a generic strategy with the pair i want it to trade or having a strategy that is optimised for a certain set of (multiple) coins.

Anyway, for now I implemented a quick pair class and pulled the pair dependency out of the exchange, for you to have a look.
Tell me what you think.

Cheers

@cxkoda cxkoda linked a pull request Apr 20, 2021 that will close this issue
@nicolasbonnici
Copy link
Owner

This is a good idea, I used to rewrite this project using PHP8 and Symfony, in this other project I have a Market entity which only contain an exchange reference and the base and quote assets pair to support multi exchange feature.

@nicolasbonnici nicolasbonnici linked a pull request Aug 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants