Skip to content

Commit

Permalink
Remove assert on missing IMS Services/AAA
Browse files Browse the repository at this point in the history
  • Loading branch information
davidkneipp committed Jan 30, 2024
1 parent 1a92ce5 commit 897a9df
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [1.0.1] - 2023-01-23


### Removed
- Assert on missing "IMS Services" for AAA/Audio Request

### Changed

- Reduced verbosity of failing subscriber lookups to debug
Expand Down
4 changes: 2 additions & 2 deletions lib/diameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -2903,8 +2903,8 @@ def Answer_16777236_265(self, packet_vars, avps):
try:
afApplicationIdentifier = self.get_avp_data(avps, 504)[0]
mediaType = self.get_avp_data(avps, 520)[0]
assert(bytes.fromhex(afApplicationIdentifier).decode('ascii') == "IMS Services")
assert(int(mediaType, 16) == 0)
# In order to send a Gx RAR, we need to ensure that mediaType is AUDIO(0) or VIDEO(1)
assert(int(mediaType, 16) == 0 or int(mediaType, 16) == 1)

# At this point, we know the AAR is indicating a call setup, so we'll get the serving pgw information, then send a
# RAR to the PGW over Gx, asking it to setup the dedicated bearer.
Expand Down

0 comments on commit 897a9df

Please sign in to comment.