Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enter Nix Shell Step does not reflect failure status back to github #22

Closed
medoror-mo opened this issue Oct 30, 2024 · 1 comment · Fixed by #23
Closed

Enter Nix Shell Step does not reflect failure status back to github #22

medoror-mo opened this issue Oct 30, 2024 · 1 comment · Fixed by #23

Comments

@medoror-mo
Copy link

Problem Description: Subsequent pipeline steps are failing due to misconfigured attributes in my Nix configuration within the Nix flake. Ideally, I would prefer the pipeline to fail immediately at the Enter Nix Step when any errors occur to prevent unnecessary downstream failures.

Proposed Solution: Modify the Enter Nix Step to exit immediately upon encountering an error in the Nix configuration, ensuring other pipeline steps aren’t triggered when prerequisites are unmet.

image
@nicknovitski nicknovitski mentioned this issue Nov 12, 2024
Merged
@nicknovitski
Copy link
Owner

I've just released v1.2.1 with a fix for this. Thank you so much for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve exit status of nix develop nicknovitski/nix-develop
2 participants
@nicknovitski @medoror-mo