Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False profanity hit on a non wildcard blacklist item #5

Open
dkachele opened this issue Jan 12, 2019 · 1 comment
Open

False profanity hit on a non wildcard blacklist item #5

dkachele opened this issue Jan 12, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@dkachele
Copy link

Summary
Received a false positive for profanity on a new issue submission for the word "Supersedes", I'm guessing it was triggered by a pattern match on the blacklist item "perse" however this item does not have wildcards.

Contents of profanity.yml

# Configuration for probot-profanity - https://github.com/nickgarlis/probot-profanity

# Language to detect profanity in.
# Choose one of the following: 'de', en', 'es', 'fr', 'it', 'nl', 'pt', 'ru'
language: 'en'

# Set to true to censor issues (defaults to false)
censor: true

# Placeholder to replace the letters of a forbidden word
placeholder: '*'

# A list of extra forbidden words. Set to `[]` to disable
extraWords: []

# A list of forbidden words to be ignored. Set to `[]` to disable
exemptWords: []

# Number of days of inactivity before an inappropriate Issue or Pull Request is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as inappropriate.
daysUntilClose: false

# Issues or Pull Requests with these labels will never be considered inappropriate. Set to `[]` to disable
exemptLabels: []

# Set to true to ignore issues in a project (defaults to false)
exemptProjects: false

# Set to true to ignore issues in a milestone (defaults to false)
exemptMilestones: false

# Label to use when marking as inappropriate
profanityLabel: inappropriate

# Comment to post when marking as profanity. Set to `false` to disable
markComment: >
  This issue has been automatically marked as inappropriate because it contains forbidden words.

# Comment to post when removing the inappropriate label.
# unmarkComment: >
#   Your comment here.

# Comment to post when closing an inappropriate Issue or Pull Request.
# closeComment: >
#   Your comment here.

# Limit the number of actions per hour, from 1-30. Default is 30
limitPerRun: 30

# Limit to only `issues` or `pulls`
# only: issues

# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls':
# pulls:
#   markComment: >
#   This issue has been automatically marked as inappropriate because
#   it contains forbidden words. It will be closed if no further edit
#   occurs. Thank you for your contributions.

# issues:
#   exemptLabels:
#     - somelabel
@nickgarlis nickgarlis added the bug Something isn't working label Mar 6, 2019
@nickgarlis
Copy link
Owner

@dkachele Hi, thank you for reporting this bug! My apologies for the late reply, I totally missed this issue.

It appears that this word still gets filtered even after discarding the word "perse" from the blacklist. I will try testing it on another instance of the bot because I still cannot reproduce this problem locally.

Regardless it looks like I need a more stable dependency for filtering words. I will work on it when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants