Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved windows and internal settings share same namespace #35

Open
cspotcode opened this issue Apr 13, 2017 · 0 comments
Open

Saved windows and internal settings share same namespace #35

cspotcode opened this issue Apr 13, 2017 · 0 comments

Comments

@cspotcode
Copy link

If you save a window named "savedWindowNames" then all your saved windows disappear. I know this isn't exactly likely to happen, but it's still possible and straightforward to avoid.

A more likely example is naming a saved window "version" which would break the update messages.

I think the simplest fix is saving windows as localStorage['savedWindow-' + nameOfWindow];, essentially putting them in their own namespace.

@cspotcode cspotcode changed the title Saves windows and internal settings share same namespace Saved windows and internal settings share same namespace Apr 13, 2017
cspotcode added a commit to cspotcode/simple-window-saver that referenced this issue Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant