Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.databases.add_alias is missing parameters #213

Open
epage opened this issue Sep 11, 2017 · 6 comments
Open

System.databases.add_alias is missing parameters #213

epage opened this issue Sep 11, 2017 · 6 comments

Comments

@epage
Copy link
Contributor

epage commented Sep 11, 2017

Looking at the LabVIEW API, XNET Database Add Alias seems to have

  • CAN FD ISO mode
  • default FD baud rate
  • ignore application protocol

in addition to default baud rate and filepath of System.databases.add_alias.

@epage epage added this to the 1.0 milestone Sep 11, 2017
@epage
Copy link
Contributor Author

epage commented Sep 11, 2017

I marked this as a breaking-change, depending on how the API gets exposed. There are ways of implementing it without breaking the API.

@jashnani
Copy link

@lilesj: We should consult with J. Smith regarding this. add_alias has complex underlying implementation/behavior.

@jashnani jashnani modified the milestones: 1.0, 0.4 Dec 14, 2017
@d-bohls d-bohls self-assigned this Jan 30, 2018
@d-bohls
Copy link
Contributor

d-bohls commented Apr 3, 2018

@sjasonsmith

Jason,

Can you give your input on this change? Is this something we should do in the python API?

It's not immediately clear to me if this is doable with just the C API, or if we would have to duplicate any implementation logic and state that is potentially being maintained in nixlvapi.dll.

@sjasonsmith
Copy link

There isn't any way to do this through the C API right now. C users currently have to interactively add an alias through the database editor, where a dialog will prompt for these values.

I would suggest NOT implementing anything in Python right now (there isn't any good way to do it anyway!). This should be escalated to be resolved in the C interface, at which point it should be exposed through Python.

@d-bohls
Copy link
Contributor

d-bohls commented Apr 4, 2018

Talked with @jashnani. We're closing this issue since it is gated on adding the functionality to the C API. If/when these properties are available in the C API, we will revisit this issue.

@d-bohls d-bohls closed this as completed Apr 4, 2018
@d-bohls d-bohls removed this from the 0.4 milestone Apr 4, 2018
@d-bohls d-bohls reopened this Apr 4, 2018
@d-bohls
Copy link
Contributor

d-bohls commented Apr 4, 2018

Change of plan; we're going to leave the issue open in case that helps keep it on our radar, though it will continue to be blocked until the C API supports these properties.

@d-bohls d-bohls removed their assignment Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants