Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to import messages if the terminal and sub addresses are same for two messages which are differ by Direction (Rx/Tx) #263

Open
KishorBasavaraju-NI opened this issue Dec 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KishorBasavaraju-NI
Copy link

Describe the bug
Not able to import messages if the terminal and sub addresses are same for two messages which are differ by Direction (Rx/Tx).

To Reproduce
Steps to reproduce the behavior:

  1. Install the Ballard MIL-STD-1553 Custom Device 24.5.0 (2024 Q3).
  2. Download the attached file Parameters_Same RT_SA.xml
  3. Open the file in a text editor and observe that there are Rx and Tx messages configured with the same RT address and sub address. 4. 4. For example, BC to RT3 (AS01) and RT3 to BC (SA01) have the same terminal address (3) and subaddress (1).
  4. Create a new VeriStand SDF and add the Ballard MIL-STD-1553 custom device.
    I6. n the Configuration Files section, select the Parameters_Same RT_SA.xml.

Actual behavior
You will see that each RT shows up, but only the RT to BC message words is added to the system definition.

Expected behavior
Both messages should have been imported

@KishorBasavaraju-NI KishorBasavaraju-NI added the bug Something isn't working label Dec 4, 2024
@KishorBasavaraju-NI
Copy link
Author

Parameters_Same RT_SA.xml

<?xml version="1.0"?>
<parameters xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
	<channel>
		<hardwareChannel>0</hardwareChannel>
		<terminals>
			<terminal>
				<terminalAddress>3</terminalAddress>
			</terminal>
			<terminal>
				<terminalAddress>4</terminalAddress>
			</terminal>
			<terminal>
				<terminalAddress>5</terminalAddress>
			</terminal>
			<terminal>
				<terminalAddress>6</terminalAddress>
			</terminal>
		</terminals>
		<majorFrames>
			<majorFrame>
				<name>MajorFrame1</name>
				<minorFrameRefs>
					<minorFrameRef>MinorFrame1</minorFrameRef>
				</minorFrameRefs>
			</majorFrame>
		</majorFrames>
		<minorFrames>
			<minorFramePeriod>10000</minorFramePeriod>
			<minorFrame>
				<name>MinorFrame1</name>
				<messageRefs>
					<messageRef>BC to RT3 (SA01)</messageRef>
					<messageRef>BC to RT4 (SA01)</messageRef>
					<messageRef>BC to RT5 (SA01)</messageRef>
					<messageRef>BC to RT6 (SA01)</messageRef>
					<messageRef>RT3 to BC (SA01)</messageRef>
					<messageRef>RT4 to BC (SA01)</messageRef>
					<messageRef>RT5 to BC (SA01)</messageRef>
					<messageRef>RT6 to BC (SA01)</messageRef>
				</messageRefs>
			</minorFrame>
		</minorFrames>
		<acyclicFrames>
			<acyclicFrame>
				<name>acyclicFrame1</name>
				<createTriggerChannel>true</createTriggerChannel>
				<messageRefs>
					<messageRef>MC 17</messageRef>
				</messageRefs>
			</acyclicFrame>
		</acyclicFrames>
		<messages>
			<message>
				<name>BC to RT3 (SA01)</name>
				<address>
					<terminalAddress>3</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Rx</direction>
				</address>
				<messageType>BC to RT</messageType>
				<numberOfWords>2</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>BC to RT4 (SA01)</name>
				<address>
					<terminalAddress>4</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Rx</direction>
				</address>
				<messageType>BC to RT</messageType>
				<numberOfWords>3</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>BC to RT5 (SA01)</name>
				<address>
					<terminalAddress>5</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Rx</direction>
				</address>
				<messageType>BC to RT</messageType>
				<numberOfWords>3</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>BC to RT6 (SA01)</name>
				<address>
					<terminalAddress>6</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Rx</direction>
				</address>
				<messageType>BC to RT</messageType>
				<numberOfWords>3</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>RT3 to BC (SA01)</name>
				<address>
					<terminalAddress>3</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Tx</direction>
				</address>
				<messageType>RT to BC</messageType>
				<numberOfWords>5</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>RT4 to BC (SA01)</name>
				<address>
					<terminalAddress>4</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Tx</direction>
				</address>
				<messageType>RT to BC</messageType>
				<numberOfWords>5</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>RT5 to BC (SA01)</name>
				<address>
					<terminalAddress>5</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Tx</direction>
				</address>
				<messageType>RT to BC</messageType>
				<numberOfWords>5</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
			<message>
				<name>RT6 to BC (SA01)</name>
				<address>
					<terminalAddress>6</terminalAddress>
					<subAddress>1</subAddress>
					<direction>Tx</direction>
				</address>
				<messageType>RT to BC</messageType>
				<numberOfWords>5</numberOfWords>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
                        <message>
				<name>MC 17</name>
				<address>
					<terminalAddress>1</terminalAddress>
					<subAddress>31</subAddress>
					<direction>Rx</direction>
				</address>
				<messageType>MC</messageType>
				<numberOfWords>1</numberOfWords>
				<modeCode>17</modeCode>
				<createTimestampChannel>true</createTimestampChannel>
			</message>
		</messages>
	</channel>
</parameters>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant