From c86af1e1516ff454bb1f1d2f3ee64e060922cba7 Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Mon, 9 Dec 2024 15:10:26 -0600 Subject: [PATCH 1/5] Disable failing rich-text tests in Firefox --- .../src/rich-text/models/tests/markdown-serializer.spec.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts index bac3489a91..aa2680fa6d 100644 --- a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts +++ b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts @@ -337,7 +337,8 @@ Plain text 3`); `); }); - it('Mention node', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2488 + it('Mention node #SkipFirefox', async () => { await appendUserMentionConfiguration(element, [ { key: 'user:1', displayName: 'username1' } ]); @@ -347,7 +348,8 @@ Plain text 3`); expect(element.getMarkdown()).toEqual(' '); }); - it('Multiple Mention node of same type', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2488 + it('Multiple Mention node of same type #SkipFirefox', async () => { await appendUserMentionConfiguration(element, [ { key: 'user:1', displayName: 'username1' }, { key: 'user:2', displayName: 'username2' } From e8b2846e800b10a87fe62ce28a2ea12e9fddadf7 Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Mon, 9 Dec 2024 15:10:58 -0600 Subject: [PATCH 2/5] Change files --- ...le-components-b8f24320-d835-42a0-b1d8-1b183206df94.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json diff --git a/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json b/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json new file mode 100644 index 0000000000..723a53c05d --- /dev/null +++ b/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json @@ -0,0 +1,7 @@ +{ + "type": "none", + "comment": "Disable failing rich-text tests in Firefox", + "packageName": "@ni/nimble-components", + "email": "20542556+mollykreis@users.noreply.github.com", + "dependentChangeType": "none" +} From 52730a72650d734c897b698c1426c10834b551a0 Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Mon, 9 Dec 2024 16:14:22 -0600 Subject: [PATCH 3/5] Update table-column-duration-text.spec.ts --- .../duration-text/tests/table-column-duration-text.spec.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts b/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts index 540a6e9235..bac0d350e9 100644 --- a/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts +++ b/packages/nimble-components/src/table-column/duration-text/tests/table-column-duration-text.spec.ts @@ -142,7 +142,8 @@ describe('TableColumnDurationText', () => { expect(tablePageObject.getCellTitle(0, 0)).toEqual(''); }); - it('removes title on mouseout of cell', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2490 + it('removes title on mouseout of cell #SkipFirefox', async () => { table.style.width = '100px'; await table.setData([{ field: 8607022000 }]); await waitForUpdatesAsync(); @@ -161,7 +162,8 @@ describe('TableColumnDurationText', () => { ); }); - it('updates displayed date when lang token changes', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2490 + it('updates displayed date when lang token changes #SkipFirefox', async () => { await table.setData([{ field: 8607022000 }]); await waitForUpdatesAsync(); expect(tablePageObject.getRenderedCellTextContent(0, 0)).toBe( From 97aef4b80512de49d5deb534c0035a141c5cdc3d Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Mon, 9 Dec 2024 16:14:50 -0600 Subject: [PATCH 4/5] Update @ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json --- ...-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json b/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json index 723a53c05d..8c2d592396 100644 --- a/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json +++ b/change/@ni-nimble-components-b8f24320-d835-42a0-b1d8-1b183206df94.json @@ -1,6 +1,6 @@ { "type": "none", - "comment": "Disable failing rich-text tests in Firefox", + "comment": "Disable failing tests in Firefox", "packageName": "@ni/nimble-components", "email": "20542556+mollykreis@users.noreply.github.com", "dependentChangeType": "none" From 10c2ba50ae9dd674fb6ed3112ae61d346b21d7d1 Mon Sep 17 00:00:00 2001 From: mollykreis <20542556+mollykreis@users.noreply.github.com> Date: Mon, 9 Dec 2024 16:42:48 -0600 Subject: [PATCH 5/5] disable more tests --- packages/nimble-components/src/table/tests/table.spec.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/nimble-components/src/table/tests/table.spec.ts b/packages/nimble-components/src/table/tests/table.spec.ts index f70939ba18..82aadfc841 100644 --- a/packages/nimble-components/src/table/tests/table.spec.ts +++ b/packages/nimble-components/src/table/tests/table.spec.ts @@ -2620,7 +2620,8 @@ describe('Table', () => { await waitForUpdatesAsync(); } - it('maintains scroll position if data does not change', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2491 + it('maintains scroll position if data does not change #SkipFirefox', async () => { await setDataAndScrollToBottom(largeData200); const scrollTopBeforeDisconnect = element.viewport.scrollTop; const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData200); @@ -2634,7 +2635,8 @@ describe('Table', () => { ); }); - it('updates scroll position if data length is reduced while not attached', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2491 + it('updates scroll position if data length is reduced while not attached #SkipFirefox', async () => { await setDataAndScrollToBottom(largeData400); const scrollTopBeforeDisconnect = element.viewport.scrollTop; const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData400); @@ -2689,7 +2691,8 @@ describe('Table', () => { ); }); - it('adjusts the number of rendered rows when the table height decreases while not attached', async () => { + // Firefox skipped, see https://github.com/ni/nimble/issues/2491 + it('adjusts the number of rendered rows when the table height decreases while not attached #SkipFirefox', async () => { element.style.height = '500px'; await element.setData(largeData200); await waitForUpdatesAsync();