-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nimble / Spright Blazor to .NET 8 #2454
Conversation
… to start before interacting with Interactive acceptance test pages)
...space/Tests/NimbleBlazor.Tests.Acceptance.Client/NimbleBlazor.Tests.Acceptance.Client.csproj
Show resolved
Hide resolved
...s/NimbleBlazor.Tests.Acceptance.Client/Pages.InteractiveWebAssembly/DialogOpenAndClose.razor
Outdated
Show resolved
Hide resolved
packages/blazor-workspace/Tests/NimbleBlazor.Tests.Acceptance/Tests.StaticSSR/TextFieldTests.cs
Show resolved
Hide resolved
...blazor-workspace/Tests/NimbleBlazor.Tests.Acceptance/NimbleInteractiveAcceptanceTestsBase.cs
Outdated
Show resolved
Hide resolved
@atmgrifter00 can you buddy this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from initial testing, haven't looked at the code yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working my way through the changes, about 1/3 done
packages/blazor-workspace/Tests/BlazorWorkspace.Testing.Acceptance/AcceptanceTestsBase.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushing current comments relevant to open discussions
packages/blazor-workspace/NimbleBlazor/wwwroot/NimbleBlazor.lib.module.js
Outdated
Show resolved
Hide resolved
packages/blazor-workspace/NimbleBlazor/wwwroot/NimbleBlazor.lib.module.js
Outdated
Show resolved
Hide resolved
packages/blazor-workspace/Examples/Demo.Server/Properties/launchSettings.json
Show resolved
Hide resolved
packages/blazor-workspace/NimbleBlazor/wwwroot/NimbleBlazor.lib.module.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished per-file review, just want to take another look when the main open threads are resolved.
Pull Request
🤨 Rationale
Resolves #1667
👩💻 Implementation
net8.0
(formerlynet6.0
)Demo.Server
example based on new Blazor Web App templateNimbleBlazor.Tests.Acceptance.Client
: Existing tests use theInteractiveServer
render mode. The project also now supports tests usingInteractiveWebAssembly
and static SSR render modes. Add one example test for each.🧪 Testing
✅ Checklist