Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nimble / Spright Blazor to .NET 8 #2454

Merged
merged 19 commits into from
Nov 1, 2024

Conversation

msmithNI
Copy link
Contributor

@msmithNI msmithNI commented Oct 28, 2024

Pull Request

🤨 Rationale

Resolves #1667

👩‍💻 Implementation

  • Projects in Blazor solution now target net8.0 (formerly net6.0)
  • Update other .NET dependencies, and code analyzer package versions
  • Update docs
  • Re-build Demo.Server example based on new Blazor Web App template
  • Update acceptance test projects to use similar setup as Blazor Web App templates
  • NimbleBlazor.Tests.Acceptance.Client: Existing tests use the InteractiveServer render mode. The project also now supports tests using InteractiveWebAssembly and static SSR render modes. Add one example test for each.
    • TODO: Spright acceptance test project currently don't use the new setup yet. If the changes look reasonable and we want to do the same for the Spright tests, I can do so in an update.

🧪 Testing

  • Manual testing
  • Autotests (unit/acceptance) pass. New tests for Nimble for InteractiveWebAssembly / static SSR render modes.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@msmithNI
Copy link
Contributor Author

@atmgrifter00 can you buddy this PR?

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from initial testing, haven't looked at the code yet

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working my way through the changes, about 1/3 done

Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushing current comments relevant to open discussions

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished per-file review, just want to take another look when the main open threads are resolved.

@msmithNI
Copy link
Contributor Author

@jattasNI @rajsite open discussion threads should be resolved, so feel free to re-review.

@jattasNI jattasNI requested review from rajsite and jattasNI October 31, 2024 15:08
@rajsite rajsite merged commit cb7fd17 into main Nov 1, 2024
14 checks passed
@rajsite rajsite deleted the users/masmith/blazor-net8-upgrade branch November 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor .NET 8 support
4 participants