Turbosnap fix #1962
Closed
Turbosnap fix #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
force-pushed
the
users/fvisser/turbosnap-fix
branch
from
6c6729c to
1352046
Compare
m-akinc
force-pushed
the
users/fvisser/turbosnap-fix
branch
from
b412ddd to
8636bc8
Compare
rajsite
reviewed
Mar 27, 2024
.github/workflows/main.yml
Outdated
|
|
||
| # Publish to Chromatic (from any push) | ||
| - name: Publish to Chromatic | ||
| if: env.HAS_CHROMATIC_PROJECT_TOKEN == 'true' && github.event_name == 'push' | ||
| uses: chromaui/action@v11 | ||
| uses: chromaui/action@v10 | ||
| with: | ||
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} | ||
| onlyChanged: "!startsWith(github.ref, 'refs/heads/main')" # Use TurboSnap for PR builds |
There was a problem hiding this comment.
A good trigger all test to emulate running on main is to flip this condition
Suggested change
| onlyChanged: "!startsWith(github.ref, 'refs/heads/main')" # Use TurboSnap for PR builds | |
| onlyChanged: "startsWith(github.ref, 'refs/heads/main')" # Use TurboSnap for PR builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
👩💻 Implementation
🧪 Testing
✅ Checklist