Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide placeholder text for a cell #860

Closed
nate-ni opened this issue Dec 5, 2022 · 0 comments
Closed

Provide placeholder text for a cell #860

nate-ni opened this issue Dec 5, 2022 · 0 comments
Assignees
@atmgrifter00
Labels
enhancement New feature or request
Milestone
Table Milestone 2

Comments

@nate-ni
Copy link
Contributor

nate-ni commented Dec 5, 2022 •
edited
Loading

😯 Problem to Solve

Values may be waiting on server requests, calculation, etc. A developer needs to able to provide some text as a placeholder while they are waiting.

Do with

💁 Proposed Solution

🤔 Open Questions

🖼️ References/Prior Art
@nate-ni nate-ni added the needs investigation Further research is needed to identify solution label Dec 5, 2022
@nate-ni nate-ni changed the title As a developer, I would like to provide placeholder text when data is not available [Review] As a developer, I would like to provide placeholder text when data is not available Dec 5, 2022
@nate-ni nate-ni changed the title [Review] As a developer, I would like to provide placeholder text when data is not available As a developer, I would like to provide placeholder text when data is not available Dec 5, 2022
@nate-ni nate-ni added this to the Table Milestone 2 milestone Dec 6, 2022
@nate-ni nate-ni changed the title As a developer, I would like to provide placeholder text when data is not available Provide placeholder text for a cell when data is not available Dec 6, 2022
@nate-ni nate-ni changed the title Provide placeholder text for a cell when data is not available Provide placeholder text for a cell Dec 6, 2022
@nate-ni nate-ni added enhancement New feature or request and removed needs investigation Further research is needed to identify solution labels Dec 6, 2022
@atmgrifter00 atmgrifter00 mentioned this issue Dec 16, 2022
Merged
@nate-ni nate-ni moved this from Backlog to Defined/Ready to Pickup in Nimble Design System Priorities Jan 4, 2023
atmgrifter00 pushed a commit that referenced this issue Jan 5, 2023
TableColumnTextField API (#930)
7df60e8 
This is a proposal for the initial API for the column type for displaying text in a table.

- #862 
- #860
@atmgrifter00 atmgrifter00 mentioned this issue Jan 6, 2023
Merged
1 task
@jattasNI jattasNI moved this from Defined/Ready to Pickup to In progress in Nimble Design System Priorities Jan 11, 2023
rajsite added a commit that referenced this issue Jan 14, 2023
@mollykreis @jattasNI @rajsite
Implement TableColumn and TableColumnText (#947)
86ea30b 
# Pull Request

## 🤨 Rationale
- #876
- #860 
- #850 
- #875 

## 👩‍💻 Implementation

This PR introduces the APIs that will allow us to create custom column
configurations for the `Table`. Additionally, I'm introducing the first
concrete column implementation, `TableColumnText`, as this is the most
common column display.

*_Note_: This PR does _not_ include consuming the `validateCellData` API
of the `TableColumn`. There is some more discussion to be had before we
know exactly how to handle this, and there doesn't seem a strong reason
to gate this PR on figuring that out. I will be filing an issue shortly
after the completion of this PR to track that work.

## 🧪 Testing

Added unit tests, and updated `Table` story matrix to use
`TableColumnText`, exercising its API.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

Co-authored-by: mollykreis <[email protected]>
Co-authored-by: Jesse Attas <[email protected]>
Co-authored-by: Milan Raj <[email protected]>
@m-akinc m-akinc moved this from In progress to Pending in Nimble Design System Priorities Jan 30, 2023
@nate-ni nate-ni moved this from Pending to Done in Nimble Design System Priorities Jan 31, 2023
@nate-ni nate-ni closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atmgrifter00 atmgrifter00

Labels
enhancement New feature or request
Projects
Nimble Design System Priorities
Status: Done
Milestone
Table Milestone 2
Development

No branches or pull requests
2 participants
@atmgrifter00 @nate-ni