Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip support for truncated cells #857

Closed
1 of 2 tasks
Tracked by #858
nate-ni opened this issue Dec 5, 2022 · 2 comments · Fixed by #1304
Closed
1 of 2 tasks
Tracked by #858

Tooltip support for truncated cells #857

nate-ni opened this issue Dec 5, 2022 · 2 comments · Fixed by #1304
Assignees
@m-akinc
Labels
enhancement New feature or request
Milestone
Table Milestone 4

Comments

@nate-ni
Copy link
Contributor

nate-ni commented Dec 5, 2022 •
edited
Loading

😯 Problem to Solve

If a table cell (or table header cell) is too small to display the contents, it should be truncated. They user should be able to access the full content via a tooltip.

💁 Proposed Solution

🤔 Open Questions

Are there any things to make sure we address for accessibility...alt text for truncated content?
Depends on:
@nate-ni nate-ni added new component Request for a new component UX labels Dec 5, 2022
@nate-ni nate-ni added this to the Table Milestone 3 milestone Dec 5, 2022
@nate-ni nate-ni added enhancement New feature or request and removed new component Request for a new component labels Dec 5, 2022
@nate-ni nate-ni changed the title As an end user, I should be able to see the full content of a cell, if it is truncated Tooltip support for truncated cells Dec 6, 2022
@nate-ni nate-ni mentioned this issue Dec 6, 2022
Closed
2 tasks
@nate-ni nate-ni removed the UX label Dec 6, 2022
@jattasNI jattasNI mentioned this issue Jan 3, 2023
Merged
@jattasNI jattasNI mentioned this issue Mar 1, 2023
Closed
1 task
@m-akinc m-akinc mentioned this issue Mar 9, 2023
Merged
1 task
m-akinc added a commit that referenced this issue Mar 9, 2023
@m-akinc
Set title attribute in text column cell (#1092)
f7cb89f 
## 🤨 Rationale

See #857

We want a tooltip on hover that shows the full text of a table cell.
This allows the user to see the full value even when it is truncated in
the cell.

## 👩‍💻 Implementation

Every table column type has to implement this themselves, so I've
implemented it for the text column. In the cell template, I set `title`
to the same expression used for the cell value. If the value is
null/undefined, the title is the placeholder text.

## 🧪 Testing

Added unit tests for the value and placeholder cases.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@jattasNI
Copy link
Contributor

jattasNI commented Apr 5, 2023

This was largely implemented in the PR linked above but I think one piece is missing: tooltips for truncated header text. We thought about including this in another PR but I don't see it in the code or the product.

@m-akinc
Copy link
Contributor

m-akinc commented Apr 5, 2023

The change to provide tooltips for truncated header text was reverted in that dev branch before the branch was merged. Meyer had to revert it because of some issue he was dealing with, but now it seems like it can be re-applied. I believe he is going to submit it.

@m-akinc m-akinc moved this from Backlog to Current Iteration in Nimble Design System Priorities May 31, 2023
@m-akinc m-akinc self-assigned this Jun 13, 2023
@m-akinc m-akinc moved this from Current Iteration to In progress in Nimble Design System Priorities Jun 13, 2023
@m-akinc m-akinc mentioned this issue Jun 15, 2023
Merged
1 task
m-akinc added a commit that referenced this issue Jun 16, 2023
@m-akinc
Add tooltip to ellipsized table header (#1304)
58ad3aa 
## 🤨 Rationale

Fixes #857
Specifically, finishes the remaining work of adding a tooltip to header
when text is ellipsized.

## 👩‍💻 Implementation

Updated the column template and base class. Follows established pattern.

## 🧪 Testing

Added three new automated tests.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@jattasNI jattasNI moved this from In progress to Done in Nimble Design System Priorities Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-akinc m-akinc

Labels
enhancement New feature or request
Projects
Nimble Design System Priorities
Status: Done
Milestone
Table Milestone 4
Development

Successfully merging a pull request may close this issue.

Add tooltip to ellipsized table header ni/nimble
3 participants
@m-akinc @jattasNI @nate-ni