Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating a client for a specific version of a measurement plug-in #928

Open
bkeryan opened this issue Sep 24, 2024 · 1 comment
Labels
enhancement New feature or request triage New issue that needs to be reviewed

Comments

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 24, 2024

Problem to Solve

Support for client versioning in #925 always generates a client for the latest version of each service. This is the most common use case, but some users may want to generate a client for a specific version.

Proposed Solution

Add a --measurement-service-version parameter. If specified, pass it to get_measurement_stub -> resolve_service.

It could also make sense for interactive mode to display multiple versions and let the user choose.

AB#2865966

@Avinash2Suresh
Copy link
Contributor

For the --all mode, if we are planning to create clients for all versions, we need to consider how to update the module and class names for the same measurement with different versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage New issue that needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants