Request for branch and pull request permissions

[swarcojiz]

Hi Nic,

since a few weeks I am using your library in our production code and I really like your library.

But I have seen some minor topics on this library.
But before I am opening an issue for each topic and also to support you a little bit,
I would like to open pull requests directly if this is ok for you.

If you don't want to have pull requests from external guys, then this is also totally fine for me 😄

[nholthaus]

External PRs for bug fixes are always welcome. New features are welcome to buy is better to stay that discussion in an issue.

…

On Thu, Nov 24, 2022, 6:56 AM Jan Izyk ***@***.***> wrote: Hi Nic, since a few weeks I am using your library in our production code and I really like your library. But I have seen some minor topics on this library. But before I am opening an issue for each topic and also to support you a little bit, I would like to open pull requests directly if this is ok for you. If you don't want to have pull requests from external guys, then this is also totally fine for me 😄 — Reply to this email directly, view it on GitHub <#300>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACOYOH4M3UZX76PCUDOIXBLWJ5JYVANCNFSM6AAAAAASKKGFKQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[swarcojiz]

Ok nice.
I agree, that new features shall be discussed in an issue.

[swarcojiz]

Can you then change the branch permissions, that also other people can create branches?
The bugs which I have seen are:

1. The version number in master is still 2.3.2 and not 2.3.3
2. In master branch the unit test to_string_locale fails in line 1420

[nholthaus]

good catch with the version number.

For the string_locale test to succeed, you need to have a German locale installed (it's not by default). I'd make sure that's in place and see if the test still fails.

[JohelEGP]

Yeah, that's #127.