Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field "name" missing in mod description #7

Open
Pandiora opened this issue Nov 25, 2024 · 3 comments
Open

Field "name" missing in mod description #7

Pandiora opened this issue Nov 25, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Pandiora
Copy link

Pandiora commented Nov 25, 2024

I am getting this error for the mod squeak_through:

[2024-11-25T14:19:52Z INFO  facmod_rs::facmod] Searching mod: squeak-through
[2024-11-25T14:19:52Z ERROR facmod_rs] error: error decoding response body: missing field `name` at line 1 column 27
[2024-11-25T14:19:52Z ERROR facmod_rs] caused by: missing field `name` at line 1 column 27
root@debian-amp:~/.test# cd /home/amp/...

If some of the other problems could be fixed or described, your approach would be the best and only one out there, since you are using the API-Key, which seems much more secure, than using your pasword in config files:

  • correctly rename downloaded files (mod + version + .zip)
  • ignore parameters as name if possible
  • using the mod_list.json should be default
  • better explanation of how to make facmod_rs available to all users
  • better explanation on how to install your tool (cargo.io repo is not found for me, so I had to install from Github)

Installation instructions for Github could be updated (I'm running an AMP server):

  • curl https://sh.rustup.rs -sSf | sh
  • apt install pkg-config libssl-dev
  • cargo install --git https://github.com/ngraham20/facmod-rs
  • facmod-rs -c config.yaml

Well, these are multiple issues, I know, but they might give anyone a head-up who finds your mod-updater.

@ngraham20
Copy link
Owner

Hey thanks for the comments! Since this was a personal "fun" project that I haven't maintained in a while, it's possible but unlikely I'll fix much very quickly 😅 absolutely feel free to submit PRs though, I'll always be fairly quick to review/approve!

@Pandiora
Copy link
Author

Pandiora commented Dec 6, 2024

I would like to have a look into Rust, but I don't have much time (eh, Factorio, anyone?) and it would take me days or weeks to understand it or to be able to fix issues. No promises from my side since - in the end - it would not be very efficient compared to updating manually in 1-5 minutes, it would be just for fun.

@Pandiora Pandiora closed this as completed Dec 6, 2024
@ngraham20 ngraham20 reopened this Dec 6, 2024
@ngraham20
Copy link
Owner

Since this isn't actually fixed, I'm perfectly happy keeping it open. I'll throw some dev labels on it 👍

@ngraham20 ngraham20 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants