diff --git a/nglview/tests/test_widget.py b/nglview/tests/test_widget.py index a7ab11b5..8cb5b893 100644 --- a/nglview/tests/test_widget.py +++ b/nglview/tests/test_widget.py @@ -527,7 +527,7 @@ def test_show_pymatgen(): def test_show_qcelemental(): import qcelemental as qcel - mol = qcel.models.Molecule.from_data("He 0 0 0") + mol = qcel.models.Molecule.from_data("He 0 0 0") view = nv.show_qcelemental(mol) view @@ -1025,15 +1025,17 @@ def test_write_html(mock_unset): display(view) fp = StringIO() - with patch.object(embed, 'embed_snippet') as mock_embed: + with patch.object(embed, 'embed_snippet') as mock_embed_snippet: + mock_embed_snippet.return_value = 'ok' nv.write_html(fp, [view], frame_range=(0, 3)) - mock_embed.assert_called_with([tm, cm, view]) + mock_embed_snippet.assert_called_with([tm, cm, view]) mock_unset.assert_called_with() assert len(view._ngl_coordinate_resource[0]) == 3 assert len(view._ngl_coordinate_resource[1]) == 3 # box - with patch.object(embed, 'embed_snippet') as mock_embed: + with patch.object(embed, 'embed_snippet') as mock_embed_snippet: + mock_embed_snippet.return_value = 'ok' nv.write_html(fp, [HBox([view])], frame_range=(0, 3)) # FIXME: assertion? diff --git a/nglview/widget.py b/nglview/widget.py index 31837da7..c43ed204 100644 --- a/nglview/widget.py +++ b/nglview/widget.py @@ -7,7 +7,7 @@ from logging import getLogger import ipywidgets as widgets -import ipywidgets.embed +from ipywidgets import embed import numpy as np from IPython.display import display from ipywidgets import (Image, Box, DOMWidget, HBox, VBox, IntSlider, Output, Play, Widget, @@ -84,9 +84,6 @@ def write_html(fp, views, frame_range=None): >>> nglview.write_html('index.html', [view], frame_range=(0, 5)) # doctest: +SKIP """ views = isinstance(views, DOMWidget) and [views] or views - embed = ipywidgets.embed - color = None - theme = None for _, v in _INIT_VIEWS.items(): views.insert(0, v)