Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue(s) with release 2.2.1 (e.g: custom color doesn't work) #1010

Closed
hainm opened this issue Jan 6, 2024 · 4 comments
Closed

Issue(s) with release 2.2.1 (e.g: custom color doesn't work) #1010

hainm opened this issue Jan 6, 2024 · 4 comments
Assignees
Labels

Comments

@hainm
Copy link
Contributor

hainm commented Jan 6, 2024

Hi,

custom color

While I am testing NGL 2.2.1 for nglview (nglviewer/nglview#1086) , I find that the custom color doesn't work anymore

image
@ppillot
Copy link
Collaborator

ppillot commented Jan 8, 2024

Thanks for reporting this. I've noticed the same issue in a separate branch and did not realize it was still in production.

@hainm
Copy link
Contributor Author

hainm commented Jan 8, 2024

Thanks @ppillot. I look forward for the fix.

ppillot added a commit that referenced this issue Jan 9, 2024
@ppillot
Copy link
Collaborator

ppillot commented Jan 9, 2024

@hainm fix has been published to npm as v2.2.2

@hainm
Copy link
Contributor Author

hainm commented Jan 9, 2024

@ppillot I confirm the fix does work. Thank you so much, Paul.

@hainm hainm closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants