Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abc:pdf): fix ignore dependency pdfjs-dist #1641

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix(abc:pdf): fix ignore dependency pdfjs-dist #1641

merged 1 commit into from
Aug 28, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 28, 2023

Although pdfjs-dist is an optional dependency on canvas, Will be installed automatically when the dependency is installed by default; This requires a higher environment and often fails to install

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Although pdfjs-dist is an optional dependency on canvas, Will be installed automatically when the dependency is installed by default; This requires a higher environment and often fails to install
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 28, 2023

Preview is ready!

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1641 (fabb21e) into master (26023ca) will not change coverage.
The diff coverage is 0.00%.

❗ Current head fabb21e differs from pull request most recent head bf2f451. Consider uploading reports for the commit bf2f451 to get more accurate results

@@           Coverage Diff           @@
##           master    #1641   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         281      281           
  Lines        8740     8740           
  Branches     1731     1731           
=======================================
  Hits         8353     8353           
  Misses        319      319           
  Partials       68       68           
Files Changed Coverage Δ
packages/abc/pdf/pdf.component.ts 38.65% <0.00%> (ø)
packages/abc/pdf/pdf.types.ts 100.00% <ø> (ø)

@cipchk cipchk merged commit b987bab into master Aug 28, 2023
8 checks passed
@cipchk cipchk deleted the issues-pdfjs branch August 28, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants