-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented MSISENSORPRO tumor-only analysis #1737
base: dev
Are you sure you want to change the base?
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 2.14.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
MSISENSORPRO_SCAN(fasta) | ||
msisensorpro_scan = MSISENSORPRO_SCAN.out.list.map{ meta, list -> [list] } | ||
versions = versions.mix(MSISENSORPRO_SCAN.out.versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we can put in the PREPARE* subworkflows together with other reference computations for tools?
@@ -177,7 +189,7 @@ workflow NFCORE_SAREK { | |||
rt_file = PREPARE_GENOME.out.rt_file | |||
|
|||
// Tabix indexed vcf files | |||
bcftools_annotations_tbi = params.bcftools_annotations ? params.bcftools_annotations_tbi ? Channel.fromPath(params.bcftools_annotations_tbi).collect() : PREPARE_GENOME.out.bcftools_annotations_tbi : Channel.empty([]) | |||
bcftools_annotations_tbi = params.bcftools_annotations ? params.bcftools_annotations_tbi ? Channel.fromPath(params.bcftools_annotations_tbi).collect() : PREPARE_GENOME.out.bcftools_annotations_tbi : Channel.value([]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged your PR, so If you merge in dev this should hopefully be fixed already
@@ -175,11 +174,10 @@ workflow BAM_VARIANT_CALLING_SOMATIC_ALL { | |||
} | |||
|
|||
// MSISENSOR | |||
if (tools.split(',').contains('msisensorpro')) { | |||
if (tools.split(',').contains('msisensorpro') && msisensorpro_scan) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be strictly necessary since the empty channel should skip the tool
MSISENSORPRO_MSISOMATIC(cram.combine(intervals_bed_combined), fasta.map{ meta, fasta -> [ fasta ] }, msisensorpro_scan) | ||
|
||
versions = versions.mix(MSISENSORPRO_MSISOMATIC.out.versions) | ||
out_msisensorpro = out_msisensorpro.mix(MSISENSORPRO_MSISOMATIC.out.output_report) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason you are not emitting the output of the workflow anymore?
@@ -109,6 +111,13 @@ workflow BAM_VARIANT_CALLING_TUMOR_ONLY_ALL { | |||
versions = versions.mix(BAM_VARIANT_CALLING_FREEBAYES.out.versions) | |||
} | |||
|
|||
// MSISENSOR | |||
if (tools.split(',').contains('msisensorpro') && msisensorpro_baseline) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar here, if the baseline is require than the tool shouldn't run on an empty channel
@@ -12,7 +12,6 @@ include { BWA_INDEX as BWAMEM1_INDEX } from '../../../modules/nf- | |||
include { BWAMEM2_INDEX } from '../../../modules/nf-core/bwamem2/index/main' | |||
include { DRAGMAP_HASHTABLE } from '../../../modules/nf-core/dragmap/hashtable/main' | |||
include { GATK4_CREATESEQUENCEDICTIONARY } from '../../../modules/nf-core/gatk4/createsequencedictionary/main' | |||
include { MSISENSORPRO_SCAN } from '../../../modules/nf-core/msisensorpro/scan/main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason to move this out?
Implements #1599 and #330
MSIsensorpro now also works with tumor-only samples if a baseline is provided by the user:
msisensor-pro pro
tumor-only analysis using the new module: Added new module: msisensorpro/msitumoronly modules#6350params.msisensorpro_baseline
will trigger tumor-only analysis independently from paired analysismsisensorpro_baseline
: https://github.com/xjtu-omics/msisensor-pro/wiki/Best-Practicesmsisensorpro_scan
toparams
supporting user-provided reference msi list for paired analysisPR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).