Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language server errors #7026

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

matthdsm
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@matthdsm matthdsm requested a review from a team as a code owner November 20, 2024 12:52
@matthdsm
Copy link
Contributor Author

@adamrtalbot, added your fix here

@matthdsm
Copy link
Contributor Author

Tests will never pass, because bwa_index is a dependency of @famosab 's parabricks test and can't run on CPU.

I guess this will be an issue for a great many of modules/subworkflows

@matthdsm
Copy link
Contributor Author

Is somebody from @nf-core/core willing to take a chance on me and merge this without passing tests? I've already got 3 approvals, but the tests can never pass because of a GPU dependency.

@sateeshperi sateeshperi merged commit 2d20463 into nf-core:master Nov 21, 2024
24 of 39 checks passed
@matthdsm
Copy link
Contributor Author

Thanks @sateeshperi

@matthdsm matthdsm deleted the fix-language-server-linting branch November 21, 2024 08:33
@famosab
Copy link
Contributor

famosab commented Nov 21, 2024

@matthdsm sorry 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants