Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost experiment remains if initExp fails #204

Open
dconathan opened this issue Jul 26, 2017 · 1 comment
Open

Ghost experiment remains if initExp fails #204

dconathan opened this issue Jul 26, 2017 · 1 comment

Comments

@dconathan
Copy link
Contributor

I believe this is an unintended consequence of #183

Basically if initExp fails, the experiment doc still exists because it was created before initExp was called, so the experiment will still show up on the dashboard... but if you click on the link you get a Internal Server Error and error messages like:

nextbackenddocker_1  |   File "/next_backend/next/api/resource_manager.py", line 222, in get_algs_for_exp_uid
nextbackenddocker_1  |     for alg in args['alg_list']:
nextbackenddocker_1  | TypeError: 'NoneType' object has no attribute '__getitem__'

Probably the easiest way to fix this is to have a try/except clause around myApp.initExp that cleans up after itself if initExp fails. Any other ideas? Could this ever backfire?

@dconathan
Copy link
Contributor Author

Just noticed that App.initExp already has a try/except clause so this is probably what we should do:
https://github.com/nextml/NEXT/blob/master/next/apps/App.py#L96-L117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant