Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do_not_ask_list #129

Open
lalitkumarj opened this issue Aug 5, 2016 · 4 comments
Open

do_not_ask_list #129

lalitkumarj opened this issue Aug 5, 2016 · 4 comments

Comments

@lalitkumarj
Copy link
Member

This used to be implemented in the App.py list (pre redux). I now see no reference to it in PoolBasedTripletMDS or DuelingBandits. We should make sure to reimplement it...this is also a good argument to not delete the dev branch (perhaps rename it to legacy) just to confirm that everything made it.

@stsievert
Copy link
Member

stsievert commented Aug 5, 2016

This should be an alg level decision -- what if the alg developer wants to ask the same question twice (e.g., like I did in validation sampling for triplets).

I'm pro keeping dev around but renaming to legacy.

@kgjamieson
Copy link
Contributor

The do not ask list is handed to the alg without taking any action, the alg
can choose to not pay attention to it

On Thursday, August 4, 2016, Scott Sievert [email protected] wrote:

This should be an alg level decision -- what if the alg developer wants to
ask the same question twice (e.g., like I did in validation sampling).

I'm pro keeping dev around but renaming to legacy.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#129 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACHgBx2z-sWfLiwNxmNh3e4OZQXI3bgbks5qcpFpgaJpZM4JdP49
.

@lalitkumarj
Copy link
Member Author

Was the do_not_ask_list put back in? This is important to have in place before any psych experiment happen.

@stsievert
Copy link
Member

I think CardinalBandits has it, but we're definitely missing an example of this in the docs.

Also, we should probably do a name change. Maybe previois_questions instead of do_not_ask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants