Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Fix(plaintext): multiple linebreaks at end #6562

Merged
merged 2 commits into from
Dec 10, 2024
Merged

[stable29] Fix(plaintext): multiple linebreaks at end #6562

merged 2 commits into from
Dec 10, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 23, 2024

Backport of PR #6508

@backportbot backportbot bot added this to the Nextcloud 29.0.9 milestone Oct 23, 2024
@max-nextcloud max-nextcloud force-pushed the backport/6508/stable29 branch from cdc707b to 1e543a7 Compare October 24, 2024 16:47
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
Merged
4 tasks
@Altahrim Altahrim changed the title [stable29] [stable30] Fix(plaintext): multiple linebreaks at end [stable29] Fix(plaintext): multiple linebreaks at end Oct 30, 2024
@Altahrim
Copy link

CI sounds related

This was referenced Nov 5, 2024
Merged
Merged
This was referenced Nov 27, 2024
Merged
Closed
@blizzz blizzz mentioned this pull request Dec 5, 2024
Merged
juliusknorr
juliusknorr requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-nextcloud Please have a look

@max-nextcloud
fix(plaintext): allow adding multiple empty lines at the end
43bbff3 
Pressing enter three times exits a CodeBlock element by default.
Disable this by setting `exitOnTripleEnter` to false in plaintext editor.

Signed-off-by: Max <[email protected]>
@max-nextcloud
test(plaintext) add regression test for newlines
116a483 
Signed-off-by: Max <[email protected]>
@max-nextcloud
Copy link
Collaborator

I fixed the jest test.

@mejo- mejo- merged commit abae069 into stable29 Dec 10, 2024
57 of 59 checks passed
@mejo- mejo- deleted the backport/6508/stable29 branch December 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@max-nextcloud max-nextcloud

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@Altahrim @max-nextcloud @juliusknorr @mejo- @blizzz