Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to files:node:updated #6427

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Sep 18, 2024

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@mejo-
Copy link
Member

mejo- commented Sep 19, 2024

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

@luka-nextcloud
Copy link
Contributor Author

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

Sorry for not mentioning. This is a technical debt, I've added the issue on the description.

@mejo-
Copy link
Member

mejo- commented Sep 23, 2024

Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works?

@luka-nextcloud
Copy link
Contributor Author

@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR nextcloud/notes#1377) then open notes app to edit a note.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

src/components/Editor.vue Outdated Show resolved Hide resolved
@juliusknorr juliusknorr force-pushed the migrate-node-update-event branch from ae00549 to c85d586 Compare November 20, 2024 13:50
@juliusknorr
Copy link
Member

Was just reported as an issue so this likely fixes #6671

@juliusknorr
Copy link
Member

juliusknorr commented Nov 20, 2024

@luka-nextcloud luka-nextcloud force-pushed the migrate-node-update-event branch from c85d586 to 5d8984e Compare November 20, 2024 18:33
@juliusknorr juliusknorr force-pushed the migrate-node-update-event branch 2 times, most recently from 1dcb2f3 to 750f50b Compare December 3, 2024 21:22
@juliusknorr
Copy link
Member

So many cypress failures seem odd, will do another rebase.

@juliusknorr juliusknorr force-pushed the migrate-node-update-event branch from 750f50b to e592ace Compare December 4, 2024 07:33
@luka-nextcloud luka-nextcloud force-pushed the migrate-node-update-event branch from e592ace to 3c9f2e8 Compare December 6, 2024 19:21
@luka-nextcloud luka-nextcloud force-pushed the migrate-node-update-event branch from 3c9f2e8 to 01ae49b Compare December 13, 2024 08:47
@luka-nextcloud luka-nextcloud force-pushed the migrate-node-update-event branch from 01ae49b to 3da9c10 Compare December 13, 2024 08:48
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 46.88%. Comparing base (18983c9) to head (3da9c10).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor.vue 0.00% 18 Missing ⚠️
src/services/WebdavClient.ts 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6427      +/-   ##
==========================================
- Coverage   46.90%   46.88%   -0.03%     
==========================================
  Files         746      739       -7     
  Lines       33984    33999      +15     
  Branches     1239     1232       -7     
==========================================
  Hits        15940    15940              
- Misses      17424    17446      +22     
+ Partials      620      613       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luka-nextcloud luka-nextcloud merged commit c8eb7a5 into main Dec 13, 2024
61 of 64 checks passed
@luka-nextcloud luka-nextcloud deleted the migrate-node-update-event branch December 13, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Migrate to files:node:updated
4 participants