-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate to files:node:updated #6427
Conversation
@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing? |
Sorry for not mentioning. This is a technical debt, I've added the issue on the description. |
Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works? |
@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR nextcloud/notes#1377) then open notes app to edit a note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
14bedd0
to
5198716
Compare
5198716
to
ae00549
Compare
ae00549
to
c85d586
Compare
Was just reported as an issue so this likely fixes #6671 |
|
c85d586
to
5d8984e
Compare
1dcb2f3
to
750f50b
Compare
So many cypress failures seem odd, will do another rebase. |
750f50b
to
e592ace
Compare
e592ace
to
3c9f2e8
Compare
3c9f2e8
to
01ae49b
Compare
Signed-off-by: Luka Trovic <[email protected]>
01ae49b
to
3da9c10
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6427 +/- ##
==========================================
- Coverage 46.90% 46.88% -0.03%
==========================================
Files 746 739 -7
Lines 33984 33999 +15
Branches 1239 1232 -7
==========================================
Hits 15940 15940
- Misses 17424 17446 +22
+ Partials 620 613 -7 ☔ View full report in Codecov by Sentry. |
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)