Issue with Link Tooltop in Firefox

[nickian]

NextCloud version: 17.0.2
Text version: 1.1.1
Firefox: 72.0.1

I can't add links to text in Firefox. This is what it looks like. When I try to click the tooltip it just goes away.

As a side note, it would also be nice to have a source editing option in the browser, not just wysiwyg.

[ahstro]

Is this still happening and/or can someone else reproduce it? I tried in both Firefox 73.0.1 and Firefox Developer Edition 74.0b4, but it worked fine, and being on Arch, I can't easily install a previous version.

[nickian]

Yes, still an issue for me on Windows 10 and MacOS, Firefox 73.0.1. The input comes up, but doesn't look right. It's cut off on the left side and just doesn't behave the same as Chrome.

[ahstro]

Hmm, that looks like a different issue to me, specifically the menu bubble not showing up correctly on too narrow editor windows. I'll look into that right away 😊

But in which way is it behaving differently? I'll try to help with that as much as possible, but unfortunately(?) I'm getting the same behavior from all my browsers 😅

[ahstro]

The alignment issue seems to be an upstream one: ueberdosis/tiptap#239
It is allegedly fixed, but since that doesn't seem to be the case here, I asked the creator of the original PR.

Still, if something other than the alignment is off, share! 😊

[nickian]

On Mac OS, I am not able to get the textbox to appear:

On Windows, it works, but if I'm trying to add a link that happens to be on the left side of the document, the popup ends up going too far left and getting cut off. Maybe some conditional logic that says if the selected text is x pixels away from the left edge, then increase left positioning by however much is needed to not cut off.

[nickian]

Actually the left positioning issue seems to be universal. This is in Chrome on Mac OS, as an example:

[nickian]

Also, I can't help but wonder, why not just have the link icon in the menu with the rest of the items instead of this tooltip approach? Seems inconsistent and arbitrary.

[ahstro]

This app is using tiptap for the editor, so I'm assuming the Nextcloud-people didn't make a lot of the design decisions, but yeah, I agree that it seems arbitrary. It's also in tiptap where the left alignment issue is.

I don't have access to a Mac, so I can't look into that issue, unfortunately :(

[juliusknorr]

This app is using tiptap for the editor, so I'm assuming the Nextcloud-people didn't make a lot of the design decisions, but yeah, I agree that it seems arbitrary. It's also in tiptap where the left alignment issue is.

tiptap is a renderless library, which means how the UI looks and acts is actually the responsibility of the text app. The modal for the link was actually decided that way together with @jancborchardt .

[jancborchardt]

Yep, the floating bar could have other inline items as well like bolding and italic next to the link.

Anyhow – that’s a separate discussion. The issue should of course be fixed, and the bar should show properly inside the available viewport. :)

[azul]

I think this is fixed in NC 20:

• The second menu entry "Link to a file" - made the initial popup wider
• Fix link menu positioning #1045 fixed the remaining.
  Closing this for now. Feel free to reopen if it's still showing up in NC 20+