Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: translated readme.md (for the folder) doesn't show when switching language #5953

Open
4 of 8 tasks
audunmb opened this issue Jun 26, 2024 · 11 comments
Open
4 of 8 tasks
Assignees
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, … feature: rich workspaces

Comments

@audunmb
Copy link

audunmb commented Jun 26, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Readme.md-files are saved as lesmeg.md when I use Nextcloud in Norwegian. Though, when someone uses Nextcloud in English, the lesmeg.md-file is not interpreted as a readme.md-file for that folder, and it is not shown as a description for that folder.

I guess this happens with other languages as well.

Steps to reproduce

  1. Change language setting to Norwegian
  2. Add a description to a folder (which is saved as lesmeg.md)
  3. Change language setting to English
  4. Open folder and observe that the description isn't showing.

Expected behavior

Expected behaviour is that folder descriptions are shown regardless of which language the user has.

I guess the current behaviour is the result of having an option to have translated folder descriptions, but when the result is that folder descriptions aren't shown at all if a user has a different language than what is used for the default description this is a bug.

As in my case, multilingual users will have no problem reading folder descriptions in Norwegian, despite choosing English as the default language (or vice versa).

Installation method

None

Nextcloud Server version

27

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

I'm on a hosted solution by Tab.Digital, so don't have access to all the technical details of the setup. They aren't relevant for this bug.

@audunmb audunmb added 0. Needs triage bug Something isn't working labels Jun 26, 2024
@kesselb kesselb transferred this issue from nextcloud/server Jun 26, 2024
@kesselb
Copy link
Contributor

kesselb commented Jun 26, 2024

Moving to the text repository as the related code is here: https://github.com/nextcloud/text/blob/main/lib/Service/WorkspaceService.php

@max-nextcloud
Copy link
Collaborator

@audunmb Thanks for your report. You have a point. We'll need to discuss how best to address this.

@joshtrichards
Copy link
Member

Related: #5446

@XueSheng-GIT
Copy link

XueSheng-GIT commented Oct 3, 2024

@max-nextcloud is there a workaround until this is fixed? For non english and non technically skilled persons it's currently not possible to add folder descriptions.

Update: Just double checked on NC29.0.7 and realized that folder descriptions are now recognized even if those are automatically translated. Can you confirm that this issue was fixed in the meantime?

@max-nextcloud
Copy link
Collaborator

Can you confirm that this issue was fixed in the meantime?

@XueSheng-GIT I don't think anything has changed. Here's how I understand the problem:

  1. user has a different language set and creates a folder description -> folder description is named according to locale.
  2. user with a different locale visits the folder - folder description does not show.

The user in 2. may be an entirely different user, or the same user after switching the language setting.

@max-nextcloud max-nextcloud added the design Experience, interaction, interface, … label Dec 11, 2024
@max-nextcloud
Copy link
Collaborator

@marcoambrosini I think this is a UX issue - and right now I don't know any way out. Two interests are conflicting here:

  • we want to localize the Readme.md name
  • we want to render the folder description for all users.

I see different options:

  1. do not localize readme.md name
  2. hide the readme.md by default by calling it .readme.md
  3. try all translated names starting with the users locale, followed by readme.md and then all other possible translations.
  4. Live with the fact that people with different locales will not see the folder description.

Personally I don't like the name Readme.md nor the tranlation Liesmich.md. I know it since 25 years from back when it was on floppy disks 💾 . I also know it from github and the like. But I don't think average users know it - in particular not in the translated form.

@kesselb
Copy link
Contributor

kesselb commented Dec 11, 2024

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 11, 2024
@marcoambrosini
Copy link
Member

@max-nextcloud From a UX perspective, I think it's best to hide the readme.md file. We can also change the name into something you deem more appropriate.

@audunmb
Copy link
Author

audunmb commented Dec 12, 2024

One solution could be:

  1. Check if there's a readme.md in current language (and display if yes)
  2. If not, check if there's a readme.md in a default language set by admin.
  3. If not, check if there's another readme.md file and display that.

A readme.md in another language would be better than none most of the time. Multilingual users would usually grasp the contents of the readme regardless of language.

For some places there should be some more steps in part 2. For instance in Norway where we have two written variations of Norwegian (Nynorsk/Bokmål) which most can read interchangeably, but which register as different languages in a localisation setup. So 2 would be check both NO_nb (bokmål) and NO_nn (nynorsk) before defaulting to English.

@juliusknorr
Copy link
Member

@max-nextcloud From a UX perspective, I think it's best to hide the readme.md file. We can also change the name into something you deem more appropriate.

We had some discussion about using a hidden file in the past, but then it is not really discoverable on the desktop. If we consider that acceptable (I don't have a strong opinion there) then we could just go for .Readme.md and have the file hidden by default.

@max-nextcloud
Copy link
Collaborator

Thanks for the reminder about the desktop Julius.

I think we should do the following:

Creating folder description:

  • Call the file Readme.md no matter what locale the user uses.

Checking for readme file:

  • check for localized version of Readme.md
  • check for Readme.md
  • check for .Readme.md

This preserves the current behavior for existing files, avoids the problem with switching languages and enables hiding the readme file for people who are confused by it.

@max-nextcloud max-nextcloud self-assigned this Dec 17, 2024
@max-nextcloud max-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, … feature: rich workspaces
Projects
Status: 📄 To do (~10 entries)
Development

No branches or pull requests

7 participants