-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content duplicates #5420
Comments
Looks a bit suspicious, maybe this is related to the file opening process in some way. FYI @max-nextcloud @mejo- |
Just an idea, with some questions that might be worth to investigate:
|
I recently encountered this as well (on 27.1.6). Unfortunately I didn't have time to debug in that very moment. In case it happens again, probably a backup of the steps in the database could be helpful, right? |
We can confirm, at least with 28.0.2, probably also 28.0.3. |
Managed to reproduce by:
Steps seem to be still in the steps file and then reapply on top of the new base document |
A fix for a possible case is in #5470 however I currently cannot see other code paths that could lead to this |
Other code path to check text/lib/Service/ApiService.php Lines 139 to 159 in 9412ae1
|
We discussed this today and it looks like this code path is indeed the culprit:
|
This should hopefully be fixed now with all the pieces from #5476 (comment) |
In which Nextcloud versions is that bug fixed? I still see a similar symptom in Nextcloud 27.1.10 with Text 3.8.0 (I first noticed it after the update to 27.1.9, but it might have been there already). Are there any manual steps required or helpful to resolve the issue and get into a clean state? What I see that sometimes when I download the file the content is correct (only once). But content displayed in the editor (and above the file listing) is duplicate. Sometimes the duplicate content is saved to the file. I experimented with moving appdata_xyz/text/documents/ and after scan-app-data (IIRC) some files showed the content three times. |
@bugspencor thanks for your heads up. Let me ask you some questions first before I reply to yours... Questions
Answering your questions
The fixes are included in #5543 and were merged in 27.1.9.
You can clear all the current editing sessions with
Editing sessions are long running to allow reconnects when users open their laptop after a while again.
That state will be fixed by running the above command for the file in question
In this case the command won't make any difference. |
@max-nextcloud thanks for the comment. To answer your questions:
Some other information, maybe there's something relevant:
I have not yet issued any Please let me know if you need anymore info. |
Could you try to reproduce this problem from scratch - i.e. creating a new file or uploading one and then creating the problem from there? I suspect this is due to editing sessions still being around from before the update. However if you can still create the problem with a new file that could not be the case. If you can reproduce with new files... could you create a screen recording of the steps so i can try and reproduce myself? Thanks a lot for your support in tracking this down. |
I could not reproduce the problem with a new file with my account and another user's account. Probably I can reproduce the problem with other users with existing files. Can I check the session state and their files before logging in and reproducing the issues? |
|
In addition maybe we could actually add a timestamp or version identifier to the steps table so we could identify old versions in the future more easily. |
Related bugreport in Collectives: nextcloud/collectives#1270 |
Fixes: #5420 Fixes: #1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]> [skip ci]
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]> [skip ci]
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
Fixes: #5420 Fixes: nextcloud/collectives#1270 Signed-off-by: Jonas <[email protected]>
I have gotten a report about a file content being duplicated. Checking the file and when this happend I've seen the following access log
Save highlighted and some possibly suspicious large pushs
- [26/Feb/2024:17:38:07 +0000] "POST /apps/text/session/8319994/save HTTP/1.1" 200 909 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0" 1555208
The text was updated successfully, but these errors were encountered: