-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to write to document errors in readonly sessions #5223
Comments
Not sure what is best but I think we have a few options:
|
I don't think we should send awareness messages on a connection that got initiated as read-only (e.g. due to missing write privileges). My understanding is that we currently don't differentiate between "on purpose read-only" (e.g. when connecting to a document session without write privileges) and "temporary read-only" (e.g due to connectivity issues). In the former case I think we should stop the client from sending any awareness messages. In the latter case we should keep the current logic of throwing an error and retrying later. |
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
This fixes read-only clients getting 403 responses on push requests that only contain questions for updates. Fixes: #5223 Fixes: #5366 Fixes: #5368 Signed-off-by: Jonas <[email protected]>
Describe the bug
When opening Text documents in read-only mode (e.g. shared documents), Text regularly tries to send push messages to the backend that get declined:
To Reproduce
Steps to reproduce the behavior:
Screenshots
Server details:
The text was updated successfully, but these errors were encountered: