fix(makefile): Disable parallel execution of targets #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jld3103 <[email protected]>
juliusknorr
approved these changes
Oct 20, 2023
|
Failure is of course unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
I have
export MAKEFLAGS="-j$(nproc)"in my environment which allows make to spawn multiple jobs at the same time. This breaks runningmakebecause installing dependencies and compiling happens at the same time which ultimate fails.Adding this line disables any parallel execution of any targets. See https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)