-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make files settings admin configurable #49758
base: master
Are you sure you want to change the base?
Make files settings admin configurable #49758
Conversation
f673671
to
35d852d
Compare
🚧 Switched back to draft to make the settings less aggressive |
If the admin changed a value and override it, it's imperative the user is made aware of it. |
35d852d
to
d5223bc
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Not ok: in_array("foo", [true, false]); // returns true ok: in_array("foo", [true, false], true); // returns false Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
d5223bc
to
5b5ee91
Compare
nevermind: the lexicon does not offer admin configuration for default user preferences |
Hello @bromiesTM We might have an other simpler way of implementing this feature.
If this is the case, we have an easier way to do this for 31 |
is it documented somewhere? In order to us to check it? |
I just wanted to know if my description fit the expected behavior. This is the PR: #49848 but I have not started yet any discussion with other engineer if we really want the feature and if it can be implemented this way ... If we merge in this current state, the files app will need to implement the |
@bromiesTM @printminion-co the question is: do want to enforce the user settings or just charge the defaults (but still let the user change it) |
Summary
To set the config run
Checklist