Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable/hide share edit options when user can not edit the share #49747

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 10, 2024

Summary

We were still showing the user the options to edit and delete the share, but they will face an unhelpful error message when they try to continue.

Before:
image

After:
image

We could also hide the quick edit button, but I think it's nice to leave it there to still indicate the permission of the share, even if the current user can not change them.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Dec 10, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Dec 10, 2024
@provokateurin provokateurin requested review from a team, artonge, Pytal and sorbaugh and removed request for a team December 10, 2024 09:27
@provokateurin provokateurin changed the title fix(SharingEntry): Hide edit button if user can not edit share Disable/hide share edit options when user can not edit the share Dec 10, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

@provokateurin
Copy link
Member Author

/backport to stable27

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@provokateurin
Copy link
Member Author

/compile

@skjnldsv skjnldsv force-pushed the fix/files_sharing/disable-editing branch from e9e6af8 to 3a64092 Compare December 10, 2024 17:47
@skjnldsv skjnldsv disabled auto-merge December 10, 2024 17:47
@skjnldsv skjnldsv enabled auto-merge December 10, 2024 17:47
@skjnldsv skjnldsv merged commit db5be3d into master Dec 10, 2024
119 of 120 checks passed
@skjnldsv skjnldsv deleted the fix/files_sharing/disable-editing branch December 10, 2024 19:07
Copy link

backportbot bot commented Dec 10, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/49747/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable28

Copy link

backportbot bot commented Dec 12, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/49747/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/49747/stable30."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Dec 12, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/49747/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1e44c671 f2898df2 3a640929

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/49747/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/49747/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants