You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the work done for #40438, I think some little design questions remain (I'm on NC 27.1.3):
IMHO the checkbox-radio-switch list for quick permissions uses counterintuitive colors: I would expect something more immediately understandable and consistent on the first look. That could be done by setting background-color: var(--color-background-dark) to all checkbox-radio-switch__label elements, and by setting background-color: var(--color-primary-element-light) to the checked label (with the same border as the other elements).
I thought the delete share button was supposed to be moved to the bottom, as it seemed to be said in Updates to new sharing flow #40629 (comment). Because it's weird to see it as such a dominating "first possible action" above cancel and update, which are more common
On dark mode, the delete share button has a white background. Is this on purpose? It seems really strange.
How it could look (except for the Delete share button background color, that I accidentally removed in this mock-up):
edit I realize there is another potential issue: the advanced control button is preceded by an arrow down icon, which can be confusing, because it can lead to think that the last three buttons (cancel, update, delete) are the advanced control. It would be wise to replace it by an arrow right icon when the settings are hided.
The text was updated successfully, but these errors were encountered:
Thanks for pointing me those improvements! Indeed there seems to be a lot of little changes. So I guess all of those stuff are going to be delivered with NC 28 and nextcloud-vue 8? In that case this issue is soon to be outdated, so I'm going to close and to wait and see if I still have suggestions later! Thanks again :)
Since the work done for #40438, I think some little design questions remain (I'm on NC 27.1.3):
IMHO the
checkbox-radio-switch
list for quick permissions uses counterintuitive colors: I would expect something more immediately understandable and consistent on the first look. That could be done by settingbackground-color: var(--color-background-dark)
to allcheckbox-radio-switch__label
elements, and by settingbackground-color: var(--color-primary-element-light)
to the checked label (with the same border as the other elements).I thought the delete share button was supposed to be moved to the bottom, as it seemed to be said in Updates to new sharing flow #40629 (comment). Because it's weird to see it as such a dominating "first possible action" above cancel and update, which are more common
On dark mode, the delete share button has a white background. Is this on purpose? It seems really strange.
How it could look (except for the Delete share button background color, that I accidentally removed in this mock-up):
advanced control
button is preceded by an arrow down icon, which can be confusing, because it can lead to think that the last three buttons (cancel, update, delete) are the advanced control. It would be wise to replace it by an arrow right icon when the settings are hided.The text was updated successfully, but these errors were encountered: