Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sharing flow design #41397

Closed
Ornanovitch opened this issue Nov 12, 2023 · 3 comments
Closed

New sharing flow design #41397

Ornanovitch opened this issue Nov 12, 2023 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@Ornanovitch
Copy link
Contributor

Ornanovitch commented Nov 12, 2023

Since the work done for #40438, I think some little design questions remain (I'm on NC 27.1.3):

screen

  1. IMHO the checkbox-radio-switch list for quick permissions uses counterintuitive colors: I would expect something more immediately understandable and consistent on the first look. That could be done by setting background-color: var(--color-background-dark) to all checkbox-radio-switch__label elements, and by setting background-color: var(--color-primary-element-light) to the checked label (with the same border as the other elements).

  2. I thought the delete share button was supposed to be moved to the bottom, as it seemed to be said in Updates to new sharing flow #40629 (comment). Because it's weird to see it as such a dominating "first possible action" above cancel and update, which are more common

  3. On dark mode, the delete share button has a white background. Is this on purpose? It seems really strange.

How it could look (except for the Delete share button background color, that I accidentally removed in this mock-up):

screen2

  1. edit I realize there is another potential issue: the advanced control button is preceded by an arrow down icon, which can be confusing, because it can lead to think that the last three buttons (cancel, update, delete) are the advanced control. It would be wise to replace it by an arrow right icon when the settings are hided.
@Ornanovitch Ornanovitch added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Nov 12, 2023
@Ornanovitch
Copy link
Contributor Author

Hey @fenn-cs @jancborchardt :) WDYT about this proposal?

@jancborchardt
Copy link
Member

Hi @Ornanovitch, we recently had to do some changes for accessibility which cover your suggestions. :)

So I would consider this fixed. What do you think?

@Ornanovitch
Copy link
Contributor Author

Thanks for pointing me those improvements! Indeed there seems to be a lot of little changes. So I guess all of those stuff are going to be delivered with NC 28 and nextcloud-vue 8? In that case this issue is soon to be outdated, so I'm going to close and to wait and see if I still have suggestions later! Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

2 participants