Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956

Open
5 of 8 tasks
tuxmaster opened this issue Aug 18, 2023 · 1 comment · May be fixed by #49804
Open
5 of 8 tasks

[Bug]: Instance name not decoded in the "OAuth 2.0-Clients" config menu #39956

tuxmaster opened this issue Aug 18, 2023 · 1 comment · May be fixed by #49804
Labels
1. to develop Accepted and waiting to be taken care of 25-feedback bug feature: authentication good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@tuxmaster
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

When the instance name contains an special char like ' then the instance name are defaced in the "OAuth 2.0-Clients" config menu.

Steps to reproduce

  1. Add an special char to the instance name
  2. open the "OAuth 2.0-Clients" config menu

Expected behavior

When the instance name will be "Foo's Speicher" that it is called "Foo's Speicher" instant of "Foo's Speicher"
See the picture.

Installation method

Community Manual installation with Archive

Nextcloud Server version

25

Operating system

RHEL/CentOS

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

PHP Deprecated:  Optional parameter $userId declared before required parameter $filter is implicitly treated as a required parameter in /var/www/html/owncloud/apps/sharelisting/lib/Service/SharesList.php on line 193
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "XXXXXXXXXX"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "25.0.10.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "forcessl": true,
        "maxZipInputSize": 83886080,
        "allowZipDownload": true,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "log_type": "syslog",
        "loglevel": 0,
        "logtimezone": "Europe\/Berlin",
        "log_authfailip": true,
        "theme": "",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "forceSSLforSubdomains": true,
        "maintenance": false,
        "asset-pipeline.enabled": true,
        "updatechecker": true,
        "htaccess.RewriteBase": "\/",
        "filelocking.enabled": true,
        "mysql.utf8mb4": true,
        "overwrite.cli.url": "https:\/\/XXXXXXXXXX",
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "dicomviewer",
            "socialsharing_email"
        ],
        "default_phone_region": "DE",
        "memcache.local": "\\OC\\Memcache\\APCu"
    }
}

List of activated Apps

PHP Deprecated:  Optional parameter $userId declared before required parameter $filter is implicitly treated as a required parameter in /var/www/html/owncloud/apps/sharelisting/lib/Service/SharesList.php on line 193
Enabled:
  - activity: 2.17.0
  - admin_audit: 1.15.0
  - bruteforcesettings: 2.5.0
  - calendar: 4.4.4
  - camerarawpreviews: 0.8.2
  - checksum: 1.2.2
  - circles: 25.0.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contacts: 5.3.2
  - contactsinteraction: 1.6.0
  - dav: 1.24.0
  - deck: 1.8.5
  - dicomviewer: 1.2.4
  - drawio: 2.1.2
  - federatedfilesharing: 1.15.0
  - files: 1.20.1
  - files_pdfviewer: 2.6.0
  - files_retention: 1.14.1
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - guests: 2.5.0
  - lookup_server_connector: 1.13.0
  - metadata: 0.19.0
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.1
  - oauth2: 1.13.1
  - password_policy: 1.15.0
  - photos: 2.0.1
  - piwik: 0.12.0
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - quota_warning: 1.17.0
  - recommendations: 1.4.0
  - related_resources: 1.0.4
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - sharelisting: 1.1.1
  - socialsharing_email: 2.6.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - tasks: 0.15.0
  - text: 3.6.0
  - theming: 2.0.1
  - twofactor_backupcodes: 1.14.0
  - twofactor_totp: 7.0.0
  - twofactor_webauthn: 1.2.0
  - updatenotification: 1.15.0
  - viewer: 1.9.0
  - workflowengine: 2.7.0
Disabled:
  - dashboard: 7.0.0
  - encryption
  - federation: 1.6.0
  - files_external: 1.7.0
  - files_trashbin: 1.10.1
  - files_versions: 1.0.3
  - firstrunwizard: 1.0
  - logreader: 2.10.0
  - support: 1.5.0
  - suspicious_login
  - user_ldap
  - user_status: 1.2.0
  - weather_status: 1.1.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

Screenshot 2023-08-18 at 12-12-21 Sicherheit - Verwaltungs-Einstellungen - Foo's Speicher

@tuxmaster tuxmaster added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 18, 2023
@joshtrichards joshtrichards added 1. to develop Accepted and waiting to be taken care of good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 17, 2024
@byt3sage byt3sage linked a pull request Dec 11, 2024 that will close this issue
6 tasks
@byt3sage
Copy link

@joshtrichards I've just raised a PR which I hope might resolve this! I appreciate it's not a critical bug.
#49804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 25-feedback bug feature: authentication good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants