fix(shares): Wrap exceptions from password validation to set code to 400

This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <[email protected]>
nextcloud · Dec 12, 2024 · 17007f6 · 17007f6
1 parent 28d7206
commit 17007f6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/private/Share20/Manager.php b/lib/private/Share20/Manager.php
@@ -112,7 +112,12 @@ protected function verifyPassword($password) {
 		}
 
 		// Let others verify the password
-		$this->dispatcher->dispatchTyped(new ValidatePasswordPolicyEvent($password));
+		try {
+			$this->dispatcher->dispatchTyped(new ValidatePasswordPolicyEvent($password));
+		} catch (HintException $e) {
+			/* Wrap in a 400 bad request error */
+			throw new HintException($e->getMessage(), $e->getHint(), 400, $e);
+		}
 	}
 
 	/**
@@ -780,7 +785,7 @@ public function createShare(IShare $share) {
 	 * @param IShare $share
 	 * @return IShare The share object
 	 * @throws \InvalidArgumentException
-	 * @throws GenericShareException
+	 * @throws HintException
 	 */
 	public function updateShare(IShare $share, bool $onlyValid = true) {
 		$expirationDateUpdated = false;