From 006bee5adf5be11fce2a0b237cba82e4800ca662 Mon Sep 17 00:00:00 2001 From: skjnldsv Date: Wed, 11 Dec 2024 19:05:24 +0100 Subject: [PATCH] fix(files): throttle favorite with max 5 simultaneous requests Signed-off-by: skjnldsv --- apps/files/src/actions/favoriteAction.ts | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/apps/files/src/actions/favoriteAction.ts b/apps/files/src/actions/favoriteAction.ts index 52beb6e74541d..1c1057a553ec6 100644 --- a/apps/files/src/actions/favoriteAction.ts +++ b/apps/files/src/actions/favoriteAction.ts @@ -11,6 +11,7 @@ import { encodePath } from '@nextcloud/paths' import { generateUrl } from '@nextcloud/router' import { isPublicShare } from '@nextcloud/sharing/public' import axios from '@nextcloud/axios' +import PQueue from 'p-queue' import Vue from 'vue' import StarOutlineSvg from '@mdi/svg/svg/star-outline.svg?raw' @@ -18,6 +19,8 @@ import StarSvg from '@mdi/svg/svg/star.svg?raw' import logger from '../logger.ts' +const queue = new PQueue({ concurrency: 5 }) + // If any of the nodes is not favorited, we display the favorite action. const shouldFavorite = (nodes: Node[]): boolean => { return nodes.some(node => node.attributes.favorite !== 1) @@ -89,7 +92,25 @@ export const action = new FileAction({ }, async execBatch(nodes: Node[], view: View) { const willFavorite = shouldFavorite(nodes) - return Promise.all(nodes.map(async node => await favoriteNode(node, view, willFavorite))) + + // Map each node to a promise that resolves with the result of exec(node) + const promises = nodes.map(node => { + // Create a promise that resolves with the result of exec(node) + const promise = new Promise(resolve => { + queue.add(async () => { + try { + await favoriteNode(node, view, willFavorite) + resolve(true) + } catch (error) { + logger.error('Error while adding file to favorite', { error, source: node.source, node }) + resolve(false) + } + }) + }) + return promise + }) + + return Promise.all(promises) }, order: -50,