Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin settings file upload error #4075

Open
elzody opened this issue Sep 26, 2024 · 0 comments
Open

Admin settings file upload error #4075

elzody opened this issue Sep 26, 2024 · 0 comments

Comments

@elzody
Copy link
Contributor

elzody commented Sep 26, 2024

Problem
A lot of legacy code was cleaned out of the server repository, and richdocuments still relies on a lot of legacy code, unfortunately. This breaks the admin settings a bit when it comes to the global templates settings, since it relies on a legacy file upload plugin that no longer exists on the master branch of the server repository. This is also causing failing tests on the main branch of richdocuments.

Solution
We clearly need to do the same and clean out the legacy code related to the admin settings, as it's quite a mess. The solution would be to rewrite the admin settings and make them more modular and maintainable, as right now it's one giant Vue component, with a lot of legacy code being used in the template as well, and using PHP as a sort of templating language there.

@elzody elzody added enhancement New feature or request 1. to develop Waiting for a developer technical debt feature: settings labels Sep 26, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Sep 26, 2024
@elzody elzody removed the 1. to develop Waiting for a developer label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

1 participant