Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework): Correctly reload after updating account credentials #2626

Merged

Conversation

provokateurin
Copy link
Member

Basically the same fix as I did in #2200 with the bug being reintroduced in #2407.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.86%. Comparing base (0ba2f5f) to head (008b733).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2626   +/-   ##
=======================================
  Coverage   28.86%   28.86%           
=======================================
  Files         370      370           
  Lines      136544   136555   +11     
=======================================
+ Hits        39411    39422   +11     
  Misses      97133    97133           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø) Carriedforward from 0ba2f5f
cookie_store 99.48% <ø> (ø) Carriedforward from 0ba2f5f
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0ba2f5f
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 0ba2f5f
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0ba2f5f
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0ba2f5f
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0ba2f5f
neon_framework 61.43% <100.00%> (+0.09%) ⬆️
neon_http_client 93.61% <ø> (ø) Carriedforward from 0ba2f5f
neon_notifications 100.00% <ø> (ø) Carriedforward from 0ba2f5f
neon_storage 94.66% <ø> (ø) Carriedforward from 0ba2f5f
neon_talk 99.45% <ø> (ø) Carriedforward from 0ba2f5f
nextcloud 24.33% <ø> (ø) Carriedforward from 0ba2f5f
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 0ba2f5f
talk_app 98.94% <ø> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../neon_framework/lib/src/login/view/login_view.dart 88.57% <100.00%> (ø)

... and 1 file with indirect coverage changes

@provokateurin provokateurin merged commit 1079975 into main Nov 2, 2024
11 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/updating-account-credentials-reload branch November 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants