Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(talk_app): Add reactions overview dialog #2625

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

provokateurin
Copy link
Member

Closes #2092

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.90%. Comparing base (0ba2f5f) to head (ececdc4).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2625      +/-   ##
==========================================
+ Coverage   28.86%   28.90%   +0.03%     
==========================================
  Files         370      371       +1     
  Lines      136544   136616      +72     
==========================================
+ Hits        39411    39483      +72     
  Misses      97133    97133              
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 0ba2f5f
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0ba2f5f
dynamite_end_to_end_test 61.69% <ø> (ø) Carriedforward from 0ba2f5f
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0ba2f5f
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0ba2f5f
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0ba2f5f
neon_framework 61.43% <ø> (+0.09%) ⬆️
neon_http_client 93.61% <ø> (ø) Carriedforward from 0ba2f5f
neon_notifications 100.00% <ø> (ø) Carriedforward from 0ba2f5f
neon_storage 94.66% <ø> (ø) Carriedforward from 0ba2f5f
neon_talk 99.45% <ø> (ø) Carriedforward from 0ba2f5f
nextcloud 24.33% <ø> (ø) Carriedforward from 0ba2f5f
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 0ba2f5f
talk_app 99.00% <100.00%> (+0.06%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ework/packages/talk_app/lib/src/utils/helpers.dart 100.00% <100.00%> (ø)
...k/packages/talk_app/lib/src/widgets/reactions.dart 100.00% <100.00%> (ø)
...app/lib/src/widgets/reactions_overview_dialog.dart 100.00% <100.00%> (ø)

@provokateurin provokateurin merged commit bb03613 into main Nov 4, 2024
11 checks passed
@provokateurin provokateurin deleted the feat/talk_app/reactions-overview-dialog branch November 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reactions list menu to see exactly who reacted with what
2 participants