Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starring contacts #3469

Open
avinash-0007 opened this issue Jun 20, 2023 · 5 comments · May be fixed by #3471
Open

Starring contacts #3469

avinash-0007 opened this issue Jun 20, 2023 · 5 comments · May be fixed by #3471
Labels
0. Needs triage enhancement New feature or request

Comments

@avinash-0007
Copy link

avinash-0007 commented Jun 20, 2023

Is your feature request related to a problem? Please describe.

A user should be able to star contacts on NextCloud Contacts.

Describe the solution you'd like

Here is what needs to happen:

  • A contact can be starred in the nextcloud, which adds it to the starred group
  • Removing the star on a contact removes it from the group
  • When synchronizing, any new contact that is on the starred group needs to show the star highlighted

Describe alternatives you've considered

No response

Additional context

Who will use this new feature and why?

  • Users importing address books from Google contacts, which also use this starred group.
  • Users wanting to see their favorite contacts easily in the UI
  • Users syncing contacts from mobile devices with contacts apps that follow Google-like approaches to favoriting i.e. add the "starred" category to the vcard will be able to star a contact in their device and be able to see it in their cloud
@avinash-0007 avinash-0007 added 0. Needs triage enhancement New feature or request labels Jun 20, 2023
This was referenced Jun 21, 2023
@ChristophWurst
Copy link
Member

@jancborchardt @marcoambrosini @nimishavijay do we wan this?

@nimishavijay
Copy link
Member

I would say yes. I guess that on Nextcloud itself it wouldn't be frequently used, but we know that many users use NC to sync contacts on their phone, where favoriting is a much more commonly used action, so I see a strong use case for point 3.

In the UI it could be fairly straightforward since we have a common pattern for adding favorites.

  • The action could be accessed from the 3dot menu of each contact
  • there could be a navigation item "Favorites" between "All contacts" and "Not grouped"
  • If a contact is marked as favorite it would have the star in the top right corner

@ChristophWurst
Copy link
Member

How do we handle localization? I'm assuming it shouldn't always be starred but use the user's language. Yet that might be problematic when someone shares an address book, then a common name would make it language independent.

@avinash-0007 could it be possible to localize the group display name but have a consistent identifier?

@RokeJulianLockhart
Copy link

Wouldn't a better solution be to allow a user to prioritize groups; to add a manual sorting method to groups, and then add a button to add a user to a group on each contact entry? It'd certainly be more versatile. I think it'd be the better option, because other contacts apps might not call their starred contacts starred, so it'd mitigate certain sync disparities.

@Somebodyisnobody
Copy link

How do we handle localization? I'm assuming it shouldn't always be starred but use the user's language. Yet that might be problematic when someone shares an address book, then a common name would make it language independent.

@avinash-0007 could it be possible to localize the group display name but have a consistent identifier?

I would not localize it i would let the user decide how he wants to call his "starred" category

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants