Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update workflows from templates #897

Merged
merged 1 commit into from
Sep 23, 2023
Merged

ci: Update workflows from templates #897

merged 1 commit into from
Sep 23, 2023

Conversation

max-nextcloud
Copy link
Collaborator

📝 Summary

In particular this will avoid downloading cypress when not needed and make the affected runs more stable against network timeouts and failures.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests are improved by this
  • Documentation is not required

@max-nextcloud max-nextcloud requested a review from mejo- September 21, 2023 17:49
mejo-
mejo- previously requested changes Sep 22, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Apart from downgrading the referenced actions it looks good to me ☺️

.github/workflows/lint-eslint.yml Outdated Show resolved Hide resolved
@mejo- mejo- merged commit 58e29e1 into main Sep 23, 2023
30 of 33 checks passed
@delete-merged-branch delete-merged-branch bot deleted the update/workflows branch September 23, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants