Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sveltekit example app with protected and admin routes #12283

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vishnuchandrappan
Copy link

☕️ Reasoning

Not a bug. More of an improvement to the sveltekit example with proper reference to authentication and authorisation.

🧢 Checklist

  • Documentation (sort of)
  • Tests (not applicable)
  • Ready to be merged

🎫 Affected issues

📌 Resources

⚠️ Notes

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 11:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 11:58am

Copy link

vercel bot commented Nov 23, 2024

@vishnuchandrappan is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ndom91
Copy link
Member

ndom91 commented Nov 27, 2024

@vishnuchandrappan thanks for this update!

As you noticed, the deployed example is not the code yuo've edited. For context, we usually have 2 apps for each client/framework in this monorepo.

  1. The ones under apps/dev/*, like the one you edited, are designed to be used for local development only. They're the ones that should be started with the root npm script dev:sveltekit (for example).
  2. The other app you linked, is located under apps/examples/* and these are designed only to be synced to their respective demo repos and then deployed via Vercel as legit demos for folks to play around with. i.e. the apps/examples/sveltekit app is synced to nextauthjs/sveltekit-auth-example (see this file for sync details)

As a sidenote, there's another PR in flight updating the sveltekit demo app (apps/examples/sveltekit/*) here: #12287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants