Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open typescript issues #119

Closed
neozenith opened this issue May 19, 2024 · 1 comment
Closed

Fix open typescript issues #119

neozenith opened this issue May 19, 2024 · 1 comment
Labels
bug good first issue Ideal for someone wanting to get started with this repo help wanted

Comments

@neozenith
Copy link
Member

Related to #88 and #117

This project was converted from NodeJS to Typescript.

It transpiles correctly. However it was decided the open typecheck issues could be a separate issue. Dear reader… that why you find yourself here. 😊

They are summarised below:

The typescript errors can be summarised as follows:

  • src/js/communities/Communities.tsx:

    • Preact component returns array - fine with preact but a problem for the types.
    • DOM element may be null.
  • src/js/events/Meetup.tsx:

    • DOM element may be null
    • null handling of properties in event data (nullable properties defined as nullable if graphql schema doesn't say they're required)
    • Referencing property in event data that does not exist
    • indexing into object with numeric keys (map of day number to day name) with number (number is not assignable to 0 | 1 | 2 ....)
  • src/js/main.ts:

    • function is not a constructor.
@neozenith
Copy link
Member Author

This is addressed with #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Ideal for someone wanting to get started with this repo help wanted
Projects
Status: Done
Development

No branches or pull requests

1 participant