Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Alt verb to handicomms, to allow more convenient toggling #2590

Merged
merged 8 commits into from
Dec 24, 2024

Conversation

Alkheemist
Copy link
Contributor

About the PR

Added an Alt verb to RadioDeviceSystem for RadioMicrophoneComponents that calls ToggleRadioMicrophone.
Added an FTL entry for the new verb

Why / Balance

QOL change for easily toggling the mic on handicomms.

How to test

Hold down alt and click on a handicomm

Media

dotnet_19_22-09-07.mp4

dotnet_19_22-02-53

Requirements

Breaking changes

None identified.

Changelog

🆑

  • tweak: Handicomm mics can now be toggled with an alt-click

@dvir001
Copy link
Contributor

dvir001 commented Dec 19, 2024

Cool beans

@dvir001 dvir001 requested review from dvir001 and whatston3 December 19, 2024 11:18
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 19, 2024
@chrome-cirrus
Copy link
Contributor

Oh hell yeah!

@Temoffy
Copy link
Contributor

Temoffy commented Dec 19, 2024

yes please!

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, mobile radios and intercoms work well, artifacts should probably be fine as well.

Might suggest pushing this upstream.

@whatston3
Copy link
Contributor

whatston3 commented Dec 24, 2024

Just going to note this - there are two minor inconsistencies with intercoms.
First, they check that the user has access before the microphone activates - this is only an issue with the STC's traffic consoles at the moment.
Second, this alternate verb doesn't actually update the intercom's state if it is one, so the intercom UI might be inconsistent.

Fixes here - maybe not the cleanest, but it works fine: whatston3:handicom-alt-intercom

Edit: merged in the changes, going to merge the PR, tested and working.

@whatston3 whatston3 merged commit 6242d7d into new-frontiers-14:master Dec 24, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants