Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable number of banks for loading #106

Open
marshallmcdonnell opened this issue Sep 6, 2018 · 1 comment
Open

Variable number of banks for loading #106

marshallmcdonnell opened this issue Sep 6, 2018 · 1 comment
Assignees
Labels
GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab Priority: High High priority feature / fix Type: Enhancement Added feature or enhancement of current features

Comments

@marshallmcdonnell
Copy link
Member

Need to allow for a variable number of banks to be loaded into the Bragg tab.

Example:

NOMAD: 6 banks
POWGEN: 1 banks

Also, may start producing more banks for POWGEN and NOMAD based on grouping.

@marshallmcdonnell marshallmcdonnell added the Type: Enhancement Added feature or enhancement of current features label Sep 6, 2018
@marshallmcdonnell
Copy link
Member Author

marshallmcdonnell commented Sep 7, 2018

Example for POWGEN that breaks

In the screenshot below, the file /SNS/PG3/IPTS-2767/shared/2018_calibration/PG3_40265.gsa was to be loaded:
image

Yet, we get the following error:

Traceback (most recent call last):
  File "/SNS/users/j35/git/addie_dev/scripts/addie", line 885, in do_load_bragg_file
    vec_x, vec_y, vec_e = self._myController.get_bragg_data(gss_group_name, bank_id, self._currBraggXUnit)
  File "/SNS/users/j35/git/addie_dev/addie/addiedriver.py", line 264, in get_bragg_data
    assert ws_name in self._braggDataDict[ws_group_name][1], error_message
AssertionError: Bank 1 is not found in group PG3_40265_group. Available bank IDs are ['PG3_40265'].

@wdzhou do you have access to that data? If not, let me know and I can make a working example for NOMAD if it helps (or just use VULCAN data?)

@marshallmcdonnell marshallmcdonnell added GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab Priority: High High priority feature / fix labels Sep 30, 2019
@marshallmcdonnell marshallmcdonnell changed the title Bragg Tab - Variable number of banks for loading Variable number of banks for loading Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Bragg / Rietveld Tab The Bragg / Rietveld plotting tab Priority: High High priority feature / fix Type: Enhancement Added feature or enhancement of current features
Projects
None yet
Development

No branches or pull requests

2 participants