Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some students became faculty and should not be treated as students anymore #17

Open
jcohenadad opened this issue Jul 4, 2024 · 3 comments

Comments

@jcohenadad
Copy link
Member

this file list Julien's students: https://github.com/neuropoly/bibeasy/blob/main/bibeasy/formatting.py

used by bibeasy to format (eg undeline students), however, some students are no more students, yet they still publish with Julien (eg: Eva, Benjamin). So we need to add a logic in bibeasy to account for a date range for the student status.

@jcohenadad
Copy link
Member Author

One possibility is to add the start/end data of each student

@namgo
Copy link
Member

namgo commented Oct 22, 2024

For clarification, scripts/student_asterisk_helper.py will remove the asterisk from a student if they are removed from bibeasy.formatting.STUDENTS but do you want the asterisk to remain there between dates the student was a member of the lab?

@jcohenadad
Copy link
Member Author

For clarification, scripts/student_asterisk_helper.py will remove the asterisk from a student if they are removed from bibeasy.formatting.STUDENTS but do you want the asterisk to remain there between dates the student was a member of the lab?

yes exactly. And for this to work, we should not remove students from bibeasy.formatting.STUDENTS, but rather add start/end information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants